Column Chooser Help #1633
Column Chooser Help #1633
Conversation
… the help icon is clicked
|
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: e529ead (Please note that this is a fully automated comment.) |
|
@blackbaud-sky-savage retry |
|
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: e529ead (Please note that this is a fully automated comment.) |
|
@blackbaud-sky-savage retry |
|
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: e529ead (Please note that this is a fully automated comment.) |
|
@blackbaud-sky-savage retry |
|
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: e529ead (Please note that this is a fully automated comment.) |
|
@blackbaud-sky-savage retry |
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: e529ead (Please note that this is a fully automated comment.) |
Codecov Report
@@ Coverage Diff @@
## master #1633 +/- ##
==========================================
- Coverage 99.98% 99.98% -0.01%
==========================================
Files 395 395
Lines 8145 8113 -32
Branches 1198 1196 -2
==========================================
- Hits 8144 8112 -32
Misses 1 1
Continue to review full report at Codecov.
|
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: f952462 (Please note that this is a fully automated comment.) |
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: ae2cd2e (Please note that this is a fully automated comment.) |
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 55a9856 (Please note that this is a fully automated comment.) |
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 1cfca48 (Please note that this is a fully automated comment.) |
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 534f2af (Please note that this is a fully automated comment.) |
|
@blackbaud-johnly We will need to update the docs to incorporate this new input. We can chat offline if needed. |
There was a problem hiding this comment.
@Blackbaud-TrevorBurch This worked great when I tested locally. Do you mind writing a unit test to cover this behavior?
|
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 87ff6cc (Please note that this is a fully automated comment.) |
|
@Blackbaud-SteveBrush, I created a task for the documentation: #1666. |
|
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 04365bb (Please note that this is a fully automated comment.) |
|
Closing in favor of: #1686 |
#1632
I based this off of how modal's work today. The only difference is that the
helpKeyis passed in via a template binding instead of through the modal config since the column chooser is added via the template and not a service.