Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Fixed dropdown aborting click events #1640

Merged
merged 4 commits into from
Apr 23, 2018
Merged

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Apr 18, 2018

Addresses: #1537

@codecov-io
Copy link

codecov-io commented Apr 18, 2018

Codecov Report

Merging #1640 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1640   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         395      395           
  Lines        8110     8108    -2     
  Branches     1194     1194           
=======================================
- Hits         8109     8107    -2     
  Misses          1        1
Impacted Files Coverage Δ
src/modules/popover/popover.directive.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f726dba...fd4c100. Read the comment docs.

Copy link
Member

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a unit test here to ensure the old behavior doesn't creep back in, perhaps as a result of a botched merge in the future?

@Blackbaud-SteveBrush
Copy link
Member Author

@Blackbaud-PaulCrowder I added a unit test. I also confirmed that this test fails on the master branch.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit a35e457 into master Apr 23, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the fix-dropdown-click branch April 23, 2018 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants