This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Clean up button styles #1641
Merged
Clean up button styles #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 391 391
Lines 7889 7889
Branches 1152 1152
=======================================
Hits 7888 7888
Misses 1 1Continue to review full report at Codecov.
|
Blackbaud-ToddRoberts
suggested changes
Apr 19, 2018
| @@ -1,23 +1,23 @@ | |||
| <div style="margin-bottom: 20px;"> | |||
| <button | |||
| type="button" | |||
| class="sky-btn sky-btn-primary" | |||
| class="sky-btn sky-btn-default" | |||
There was a problem hiding this comment.
Can we remove the icons from these buttons as well? In general buttons should not have icons except in some narrowly defined cases.
There was a problem hiding this comment.
Sure thing. I just removed the options locally and will push them up to the PR in a sec.
Blackbaud-ToddRoberts
approved these changes
Apr 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.