Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Fix ie dropdown scroll #1642

Conversation

blackbaud-conorwright
Copy link
Contributor

Fixing issue #1536 where fullscreen dropdowns were not able to scroll in IE11 and Edge

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 0cc6974
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/368818721

(Please note that this is a fully automated comment.)

@codecov-io
Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #1642 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1642   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         395      395           
  Lines        8069     8069           
  Branches     1183     1183           
=======================================
  Hits         8068     8068           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b4012...978b0aa. Read the comment docs.

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 29e5edb
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/368832635

(Please note that this is a fully automated comment.)

@Blackbaud-SteveBrush Blackbaud-SteveBrush self-assigned this Apr 20, 2018
@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 7a0ade0
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/370102322

(Please note that this is a fully automated comment.)

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 978b0aa
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/370135479

(Please note that this is a fully automated comment.)

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit f79f252 into blackbaud:master Apr 23, 2018
@blackbaud-conorwright blackbaud-conorwright deleted the fix-ie-dropdown-scroll branch April 23, 2018 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants