This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Contrib > Checkbox and radio styles #1691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-SteveBrush
requested review from
Blackbaud-ToddRoberts,
Blackbaud-BobbyEarl and
Blackbaud-PaulCrowder
Blackbaud-ToddRoberts
suggested changes
May 16, 2018
| @@ -281,3 +281,30 @@ | |||
| margin-right: 5px; | |||
| color: $sky-highlight-color-danger; | |||
| } | |||
|
|
|||
| @mixin sky-switch-variant($bg-color-checked, $border-color-checked) { | |||
There was a problem hiding this comment.
Is there a way to ensure that regular checkbox/radio buttons only use the info variant? at this point only the icon-style versions are approved to use the other colors.
There was a problem hiding this comment.
@Blackbaud-ToddRoberts This pull request only deals with checkbox/radio, so I'll rip the other styles out of there for now.
|
Based on feedback from @Blackbaud-ToddRoberts, I'm closing this one (for now) in favor of: #1694 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original contribution: #1644
(The icon feature is still being discussed, but we'll go ahead with the style changes.)
.sky-rounded-circlewhich renders an element as a circle.