This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Reactive radio #1714
Merged
Reactive radio #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-TrevorBurch
assigned Blackbaud-TrevorBurch and unassigned Blackbaud-BobbyEarl
Blackbaud-TrevorBurch
approved these changes
Aug 21, 2018
There was a problem hiding this comment.
One small non-blocking question. @Blackbaud-SteveBrush this looks good to me but is big enough to probably need your eyes at this point as I might not know of any oddities here or there. Thanks!
src/modules/radio/radio.component.ts
Outdated
|
|
||
| /** | ||
| * Provider Expression that allows sky-checkbox to register as a ControlValueAccessor. |
There was a problem hiding this comment.
Any reason we are getting rid of the comments here and on nextId above? Seems like there wouldn't be hurt in leaving them there for clarity.
There was a problem hiding this comment.
added back in 😄
|
Resolves #1401 |
Blackbaud-AlexKingman
assigned Blackbaud-SteveBrush and unassigned Blackbaud-TrevorBurch
|
Created #1942 to document changes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original contribution: #1692
Resolves: #1401