This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix datepicker input clear (#1729) #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolving Card action bar still visable after hiding with *ngIf #1421 * Addressed PR style comments * updated demo with clear button * added datepicker support for undefined values
blackbaud-conorwright
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1730 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 409 409
Lines 8474 8477 +3
Branches 1240 1241 +1
=======================================
+ Hits 8473 8476 +3
Misses 1 1
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
suggested changes
Jun 11, 2018
| </div> | ||
|
|
||
| <p> | ||
| <button class='sky-btn sky-btn-secondary' (click)="clearSelectedDate()">Clear</button> |
There was a problem hiding this comment.
Double quotes for HTML attribute values. Also, change the button text to "Clear selected date" to be more descriptive.
| @@ -8,4 +8,8 @@ export class SkyDatepickerDemoComponent { | |||
| public minDate: Date; | |||
| public maxDate: Date; | |||
| public selectedDate: Date; | |||
|
|
|||
| public clearSelectedDate() { | |||
There was a problem hiding this comment.
Needs a return type of void.
Blackbaud-SteveBrush
approved these changes
Jun 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added datepicker support for undefined values
Resolves: #1719 and #1419