This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 65
Fix datepicker startingday #1732
Merged
Merged
Changes from 23 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
3f4222e
Resolving Card action bar still visable after hiding with *ngIf #1421
blackbaud-conorwright a450054
Addressed PR style comments
blackbaud-conorwright 4b809aa
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright d55f351
Merge branch 'master' into master
Blackbaud-SteveBrush 833bcc7
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright b553659
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright ab82ba3
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright db21c76
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright a282a86
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright d210c2b
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright 35e789d
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright 636c5dd
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright bdc97a6
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright 6104aaf
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright 37f50ec
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright 76279cd
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright 2324e90
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright d48b8f2
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright b2e318a
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright 8d52945
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright 194e01f
Merge remote-tracking branch 'upstream/master'
blackbaud-conorwright e741dcf
surfaced startingDay property on datepicker
blackbaud-conorwright 7289a84
Merge branch 'master' into fix-datepicker-startingday
Blackbaud-SteveBrush ed6d731
Merge remote-tracking branch 'upstream/master' into fix-datepicker-st…
blackbaud-conorwright f8a7fc7
move startday to input to keep options on same elem
blackbaud-conorwright 67ad279
fixed tslint issue
blackbaud-conorwright 569c2ae
Merge branch 'master' into fix-datepicker-startingday
Blackbaud-SteveBrush 1d51d90
switched to getters and setters for datepicker props
blackbaud-conorwright 5716888
Merge branch 'fix-datepicker-startingday' of github.com:blackbaud/sky…
blackbaud-conorwright 5b3e147
switched min and max back to using set func
blackbaud-conorwright b2abc1c
added default starting day to datepicker
blackbaud-conorwright File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
src/modules/datepicker/fixtures/datepicker.component.fixture.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackbaud-conorwright Is there any way we can add this input to the
datepicker-input.directive.ts
instead? The docs already mention that this input exists on the directive...https://developer.blackbaud.com/skyux/components/datepicker#datepicker-input-directive-properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved. Though it feels weird to me that the calendar's starting day would be on the Input at all, I can see why it would be weird to have an input somewhere the rest weren't