This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix wait service teardown race condition #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-SteveBrush
suggested changes
Jun 21, 2018
src/modules/wait/wait.service.ts
Outdated
| Needs to yield so that wait creation can finish | ||
| before it is dismissed in the event of a race. | ||
| */ | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Possible to reference setTimeout from SkyWindowRefService, just for consistency?
There was a problem hiding this comment.
done :)
Codecov Report
@@ Coverage Diff @@
## master #1739 +/- ##
==========================================
+ Coverage 99.98% 99.98% +<.01%
==========================================
Files 410 410
Lines 8527 8530 +3
Branches 1251 1252 +1
==========================================
+ Hits 8526 8529 +3
Misses 1 1
Continue to review full report at Codecov.
|
|
@blackbaud-conorwright The unit tests are failing for this one. Also: Is it possible to create a unit test to confirm that the race condition is no longer happening? |
|
test added |
Blackbaud-SteveBrush
approved these changes
Jun 29, 2018
Blackbaud-SteveBrush
deleted the
fix-wait-service-teardown-race-condition
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1276
Made the skywait service's pageWait teardown yield using a timeout so that the creation of the pagewait can complete before being torn down.