Flyout action button #1766

Blackbaud-StewartStephens · 2018-06-28T15:21:18Z

Code change for issue #1754

Add primary action callback for the flyout component.

blackbaud-sky-savage · 2018-06-28T15:43:42Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 2e18f43
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/397850056

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-06-28T18:16:38Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 027c1ee
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/397911377

(Please note that this is a fully automated comment.)

codecov-io · 2018-06-28T18:16:47Z

Codecov Report

Merging #1766 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1766      +/-   ##
==========================================
+ Coverage   99.98%   99.98%   +<.01%     
==========================================
  Files         410      410              
  Lines        8542     8556      +14     
  Branches     1253     1256       +3     
==========================================
+ Hits         8541     8555      +14     
  Misses          1        1

Impacted Files	Coverage Δ
src/modules/flyout/flyout.component.ts	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c16ee63...2810258. Read the comment docs.

Blackbaud-StewartStephens · 2018-06-29T14:17:58Z

I will be making a change to better support resize dragging when iframes are present on the page. Please do not review yet.

…1754-flyout-action-button

…ckbaud-StewartStephens/skyux2 into ft-1754-flyout-action-button

Blackbaud-StewartStephens · 2018-06-29T14:54:40Z

OK, should be good to review now.

blackbaud-sky-savage · 2018-06-29T15:15:06Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 660a08f
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/398283109

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-06-29T15:49:38Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: f8588bd
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/398283161

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-06-29T17:31:04Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 3647d18
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/398338912

(Please note that this is a fully automated comment.)

…ckbaud-StewartStephens/skyux2 into ft-1754-flyout-action-button

blackbaud-sky-savage · 2018-06-29T18:47:24Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 81e8a21
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/398370422

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-06-29T19:44:17Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: f3788de
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/398385779

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-07-02T12:39:00Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 6ea2424
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/399101418

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-07-02T12:53:18Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 3e78169
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/399101484

(Please note that this is a fully automated comment.)

…ckbaud-StewartStephens/skyux2 into ft-1754-flyout-action-button

blackbaud-sky-savage · 2018-07-02T15:37:49Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 67e0a6b
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/399177695

(Please note that this is a fully automated comment.)

Blackbaud-SteveBrush

@Blackbaud-StewartStephens Code looks great; just a few suggestions.

Blackbaud-SteveBrush · 2018-07-02T16:55:29Z

src/modules/flyout/flyout.component.html

+
+<ng-template #primaryActionTemplate>
+  <ng-template [ngIf]="primaryAction && primaryAction.callback">
+    <a


Since the user may not be navigating to a route or URL with this button, we should instead represent this semantically as a button.

<button class="sky-btn sky-btn-default sky-flyout-btn-primary-action" type="button" (click)="invokePrimaryAction()" > {{ primaryActionLabel }} </button>

Switched this to a button.

Blackbaud-SteveBrush · 2018-07-02T16:57:24Z

src/modules/flyout/flyout.component.scss

@@ -62,6 +62,12 @@
  }
 }

+.sky-flyout-btn-primary-action {


This style won't be needed if we convert to using <button>.

Removed this style. I left the class on the button element since the tests rely on using it as part of the selector.

Blackbaud-SteveBrush · 2018-07-02T17:12:38Z

src/modules/flyout/flyout.component.ts

+
+    // when iframes are present on the page, they may interfere with dragging
+    // temporarily disable pointer events in iframes when dragging starts
+    const iframes = document.querySelectorAll('iframe');


I'd like to research the iframe issue further (is there an issue filed for this?), but I don't want to hold up this pull request. Think we could pull this out into a different branch for now?

I removed the iframe code from this branch and moved it to branch ch-flyout-iframe in my fork. I also filed an issue #1794 to track it.

blackbaud-sky-savage · 2018-07-02T18:56:30Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 4ac1907
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/399249898

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-07-02T19:18:42Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 1e95385
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/399256784

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-07-02T19:23:09Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 0b78552
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/399256861

(Please note that this is a fully automated comment.)

Blackbaud-SteveBrush · 2018-07-02T19:19:56Z

src/modules/flyout/flyout.component.html

+  <ng-template [ngIf]="primaryAction && primaryAction.callback">
+    <button
+      class="sky-btn sky-btn-default sky-flyout-btn-primary-action"
+      href="#"


Needs type="button" (if not provided, it defaults to "submit" which could potentially trigger a form submission).

Added type="button".

Blackbaud-SteveBrush · 2018-07-02T19:23:09Z

src/modules/flyout/flyout.component.ts

@@ -39,6 +39,7 @@ import {
  SkyFlyoutMessage,
  SkyFlyoutMessageType
 } from './types';
+import { SkyFlyoutAction } from './types/flyout-action';


We should allow this type to be imported by consumers in their SPAs.

Need to include an export statement here:
https://github.com/blackbaud/skyux2/blob/master/src/modules/flyout/types/index.ts

And here:
https://github.com/blackbaud/skyux2/blob/master/src/modules/flyout/index.ts#L9-L13

Exported the type.

blackbaud-sky-savage · 2018-07-03T13:51:06Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 6dccbf3
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/399581710

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-07-03T14:16:53Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 7ba9856
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/399593705

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-07-03T15:17:59Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: b117aef
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/399622488

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-07-03T15:41:43Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 2810258
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/399630378

(Please note that this is a fully automated comment.)

Blackbaud-SteveBrush · 2018-07-03T15:49:01Z

@blackbaud-sky-savage retry

blackbaud-sky-savage · 2018-07-03T16:14:36Z

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 2810258
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/399643696

(Please note that this is a fully automated comment.)

blackbaud-johnly · 2018-09-20T17:44:15Z

Created #2014 to document the flyout action

Blackbaud-StewartStephens added 6 commits May 11, 2018 13:33

roll back microedge-rxstate to 2.0.0

c04915b

Merge branch 'master' of https://github.com/blackbaud/skyux2

69d2692

add initial primary action button work

293c9e4

update demo

c7a35be

add default label, tests

36c0908

undo microedge-rxstate version change

2e18f43

trigger pr build

027c1ee

Blackbaud-SteveBrush added the From: Consumer label Jun 29, 2018

Blackbaud-StewartStephens added 4 commits June 29, 2018 10:51

fix resizing over iframes

660a08f

Merge branch 'master' into ft-1754-flyout-action-button

f8588bd

Merge branch 'master' of https://github.com/blackbaud/skyux2 into ft-…

7fa50d6

…1754-flyout-action-button

Merge branch 'ft-1754-flyout-action-button' of https://github.com/Bla…

bb617de

…ckbaud-StewartStephens/skyux2 into ft-1754-flyout-action-button

Merge branch 'master' into ft-1754-flyout-action-button

3647d18

Blackbaud-StewartStephens added 3 commits June 29, 2018 14:25

Merge branch 'ft-1754-flyout-action-button' of https://github.com/Bla…

d0a037c

…ckbaud-StewartStephens/skyux2 into ft-1754-flyout-action-button

Merge branch 'master' into ft-1754-flyout-action-button

81e8a21

Merge branch 'ft-1754-flyout-action-button' of https://github.com/Bla…

f3788de

…ckbaud-StewartStephens/skyux2 into ft-1754-flyout-action-button

Blackbaud-StewartStephens added 2 commits July 2, 2018 08:13

try adding ticks

3e78169

Merge branch 'master' into ft-1754-flyout-action-button

6ea2424

Blackbaud-StewartStephens added 2 commits July 2, 2018 11:15

add iframe coverage

7abd75c

Merge branch 'ft-1754-flyout-action-button' of https://github.com/Bla…

67e0a6b

…ckbaud-StewartStephens/skyux2 into ft-1754-flyout-action-button

Blackbaud-SteveBrush self-assigned this Jul 2, 2018

Blackbaud-SteveBrush added this to the Block 5 Sprint 3 - 7/6/2018 milestone Jul 2, 2018

Blackbaud-SteveBrush suggested changes Jul 2, 2018

View reviewed changes

Blackbaud-StewartStephens added 3 commits July 2, 2018 14:18

switch a to button

4ac1907

remove iframe stuff

1e95385

Merge branch 'master' into ft-1754-flyout-action-button

0b78552

Blackbaud-SteveBrush suggested changes Jul 2, 2018

View reviewed changes

Merge branch 'master' into ft-1754-flyout-action-button

6dccbf3

add type button and export SkyFlyoutAction

7ba9856

remove href

b117aef

trigger build

2810258

Blackbaud-SteveBrush approved these changes Jul 3, 2018

View reviewed changes

Blackbaud-SteveBrush merged commit c0f2cb7 into blackbaud:master Jul 3, 2018

Blackbaud-AlexKingman mentioned this pull request Sep 20, 2018

Flyout > Create generic "action" button in header #1754

Closed

blackbaud-johnly mentioned this pull request Sep 20, 2018

Document flyout action #2014

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flyout action button #1766

Flyout action button #1766

Blackbaud-StewartStephens commented Jun 28, 2018

blackbaud-sky-savage commented Jun 28, 2018

blackbaud-sky-savage commented Jun 28, 2018

codecov-io commented Jun 28, 2018 •

edited

Loading

Blackbaud-StewartStephens commented Jun 29, 2018

Blackbaud-StewartStephens commented Jun 29, 2018

blackbaud-sky-savage commented Jun 29, 2018

blackbaud-sky-savage commented Jun 29, 2018

blackbaud-sky-savage commented Jun 29, 2018

blackbaud-sky-savage commented Jun 29, 2018

blackbaud-sky-savage commented Jun 29, 2018

blackbaud-sky-savage commented Jul 2, 2018

blackbaud-sky-savage commented Jul 2, 2018

blackbaud-sky-savage commented Jul 2, 2018

Blackbaud-SteveBrush left a comment

Blackbaud-SteveBrush Jul 2, 2018

Blackbaud-StewartStephens Jul 2, 2018

Blackbaud-SteveBrush Jul 2, 2018

Blackbaud-StewartStephens Jul 2, 2018

Blackbaud-SteveBrush Jul 2, 2018

Blackbaud-StewartStephens Jul 2, 2018

blackbaud-sky-savage commented Jul 2, 2018

blackbaud-sky-savage commented Jul 2, 2018

blackbaud-sky-savage commented Jul 2, 2018

Blackbaud-SteveBrush Jul 2, 2018

Blackbaud-StewartStephens Jul 3, 2018

Blackbaud-SteveBrush Jul 2, 2018

Blackbaud-StewartStephens Jul 3, 2018

blackbaud-sky-savage commented Jul 3, 2018

blackbaud-sky-savage commented Jul 3, 2018

blackbaud-sky-savage commented Jul 3, 2018

blackbaud-sky-savage commented Jul 3, 2018

Blackbaud-SteveBrush commented Jul 3, 2018

blackbaud-sky-savage commented Jul 3, 2018

blackbaud-johnly commented Sep 20, 2018

Flyout action button #1766

Flyout action button #1766

Conversation

Blackbaud-StewartStephens commented Jun 28, 2018

blackbaud-sky-savage commented Jun 28, 2018

blackbaud-sky-savage commented Jun 28, 2018

codecov-io commented Jun 28, 2018 • edited Loading

Codecov Report

Blackbaud-StewartStephens commented Jun 29, 2018

Blackbaud-StewartStephens commented Jun 29, 2018

blackbaud-sky-savage commented Jun 29, 2018

blackbaud-sky-savage commented Jun 29, 2018

blackbaud-sky-savage commented Jun 29, 2018

blackbaud-sky-savage commented Jun 29, 2018

blackbaud-sky-savage commented Jun 29, 2018

blackbaud-sky-savage commented Jul 2, 2018

blackbaud-sky-savage commented Jul 2, 2018

blackbaud-sky-savage commented Jul 2, 2018

Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blackbaud-sky-savage commented Jul 2, 2018

blackbaud-sky-savage commented Jul 2, 2018

blackbaud-sky-savage commented Jul 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blackbaud-sky-savage commented Jul 3, 2018

blackbaud-sky-savage commented Jul 3, 2018

blackbaud-sky-savage commented Jul 3, 2018

blackbaud-sky-savage commented Jul 3, 2018

Blackbaud-SteveBrush commented Jul 3, 2018

blackbaud-sky-savage commented Jul 3, 2018

blackbaud-johnly commented Sep 20, 2018

codecov-io commented Jun 28, 2018 •

edited

Loading