Fix timepicker input clear #1772
Conversation
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: fffe361 (Please note that this is a fully automated comment.) |
Codecov Report
@@ Coverage Diff @@
## master #1772 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 410 410
Lines 8585 8585
Branches 1267 1267
=======================================
Hits 8584 8584
Misses 1 1
Continue to review full report at Codecov.
|
| @@ -24,6 +24,9 @@ <h3> | |||
| <div> | |||
| Selected time is {{selectedTime1?.local}} | |||
| </div> | |||
| <p> | |||
| <button class="sky-btn sky-btn-secondary" (click)="clearSelectedTime()">Clear selected time</button> | |||
There was a problem hiding this comment.
Needs type="button". Also, let's break up the attributes into multiple lines.
|
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: e98e75e (Please note that this is a fully automated comment.) |
…-timepicker-input-clear
|
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: c5d1983 (Please note that this is a fully automated comment.) |
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 6b22508 (Please note that this is a fully automated comment.) |
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 5899ae4 (Please note that this is a fully automated comment.) |
Allows clearing of input of timepicker by setting ngModel to undefined.
Resolves: #1759