This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
added ariaRole input to modals. made confirm modal alertdialog. Added aria-modal=true to modals #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackbaud-conorwright
changed the title
Blackbaud-SteveBrush
suggested changes
Jul 3, 2018
There was a problem hiding this comment.
We should probably adjust the Error modal component's role to alertdialog (similar to Confirm component):
https://github.com/blackbaud/skyux2/blob/master/src/modules/error/error-modal-form.component.html#L1
Codecov Report
@@ Coverage Diff @@
## master #1784 +/- ##
======================================
Coverage 100% 100%
======================================
Files 412 412
Lines 8610 8614 +4
Branches 1271 1272 +1
======================================
+ Hits 8610 8614 +4
Continue to review full report at Codecov.
|
|
Updated error component too |
Blackbaud-SteveBrush
approved these changes
Jul 16, 2018
|
Created #1841 to document ariaRole property. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ariaRole parameter to modals and made the value for the confirm component 'alertdialog'
added aria-modal="true" to modals
Resolves: #1404 and #1403