This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
added default aria-label to colorpicker input #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1788 +/- ##
==========================================
+ Coverage 99.98% 99.98% +<.01%
==========================================
Files 410 410
Lines 8585 8589 +4
Branches 1267 1269 +2
==========================================
+ Hits 8584 8588 +4
Misses 1 1
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
suggested changes
Jul 3, 2018
| @@ -28,6 +28,7 @@ import { | |||
| } from './types'; | |||
|
|
|||
| import { Subscription } from 'rxjs/Subscription'; | |||
| import { SkyResourcesService } from '../resources'; | |||
There was a problem hiding this comment.
import {
SkyResourcesService
} from '../resources';
| @@ -87,7 +88,8 @@ export class SkyColorpickerInputDirective | |||
| constructor( | |||
| private elementRef: ElementRef, | |||
| private renderer: Renderer, | |||
| private service: SkyColorpickerService | |||
| private service: SkyColorpickerService, | |||
| private skyResourceSvc: SkyResourcesService | |||
There was a problem hiding this comment.
Use the keyword 'Service' to be consistent. While we're in here, we should also rename the service parameter (okay since it's private).
private colorpickerService: SkyColorpickerService,
private resourceService: SkyResourcesService
Blackbaud-SteveBrush
changed the title
blackbaud-conorwright
changed the title
|
no longer on hold. The input field is now readonly and will not be hidden |
Blackbaud-SteveBrush
approved these changes
Jul 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a default aria-label to colorpicker components for when one is not supplied
Resolves: #1381