This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
added ariaLabel to timepicker input field #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-SteveBrush
suggested changes
Jul 3, 2018
| @@ -20,7 +20,7 @@ import { TimepickerTestComponent } from './fixtures/timepicker-component.fixture | |||
|
|
|||
| const moment = require('moment'); | |||
|
|
|||
| describe('Timepicker', () => { | |||
| fdescribe('Timepicker', () => { | |||
There was a problem hiding this comment.
whoops, my bad. fixed.
| @@ -27,6 +27,7 @@ import { | |||
| Subscription | |||
| } from 'rxjs/Subscription'; | |||
| import { SkyTimepickerTimeOutput } from './timepicker.interface'; | |||
| import { SkyResourcesService } from '../resources'; | |||
There was a problem hiding this comment.
import {
SkyResourcesService
} from '../resources';
| public constructor( | ||
| private renderer: Renderer, | ||
| private elRef: ElementRef, | ||
| private skyResourceSvc: SkyResourcesService |
There was a problem hiding this comment.
For consistency...
private resourceService: SkyResourcesService
Codecov Report
@@ Coverage Diff @@
## master #1795 +/- ##
==========================================
+ Coverage 99.98% 99.98% +<.01%
==========================================
Files 410 410
Lines 8580 8585 +5
Branches 1263 1266 +3
==========================================
+ Hits 8579 8584 +5
Misses 1 1
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
approved these changes
Jul 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a default aria label to the timepicker input directive
Resolves: #862