Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Modified email validation directive to have a more restrictive regex #1813

Merged
merged 5 commits into from
Jul 12, 2018

Conversation

Blackbaud-DylanHouston
Copy link
Contributor

Addresses issue #1812

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 754fa57
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/402300850

(Please note that this is a fully automated comment.)

@Blackbaud-DylanHouston
Copy link
Contributor Author

@Blackbaud-BobbyEarl I think the build timed out. Could we try this again?

@Blackbaud-BobbyEarl
Copy link

@blackbaud-sky-savage retry

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 754fa57
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/402386961

(Please note that this is a fully automated comment.)

@Blackbaud-BobbyEarl
Copy link

@blackbaud-sky-savage retry

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 754fa57
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/402514091

(Please note that this is a fully automated comment.)

@Blackbaud-DylanHouston
Copy link
Contributor Author

@Blackbaud-BobbyEarl Thanks for running them again. I see that the check is still registering as unsuccessful. Are there any actions that I need to take? (Pardon my ignorance, but I have only worked with CI/CD in VSTS).

@Blackbaud-BobbyEarl
Copy link

I believe it's something on our end @Blackbaud-DylanHouston. Stand by for updates...

@codecov-io
Copy link

codecov-io commented Jul 11, 2018

Codecov Report

Merging #1813 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1813   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         410      410           
  Lines        8565     8565           
  Branches     1258     1258           
=======================================
  Hits         8564     8564           
  Misses          1        1
Impacted Files Coverage Δ
...les/email-validation/email-validation.directive.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e925b81...2bdf31c. Read the comment docs.

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 5409374
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/402784369

(Please note that this is a fully automated comment.)

@Blackbaud-DylanHouston
Copy link
Contributor Author

@Blackbaud-SteveBrush @Blackbaud-BobbyEarl Just an fyi -- after the changes got approved, I updated this branch through GitHub to be in sync with the main branch.

@Blackbaud-SteveBrush
Copy link
Member

@blackbaud-sky-savage retry

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 11385c2
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/403153358

(Please note that this is a fully automated comment.)

@Blackbaud-SteveBrush
Copy link
Member

@blackbaud-sky-savage retry

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 11385c2
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/403191743

(Please note that this is a fully automated comment.)

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: b028f92
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/403210424

(Please note that this is a fully automated comment.)

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 2bdf31c
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/403234083

(Please note that this is a fully automated comment.)

@Blackbaud-SteveBrush
Copy link
Member

@blackbaud-sky-savage retry

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 2bdf31c
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/403255609

(Please note that this is a fully automated comment.)

1 similar comment
@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 2bdf31c
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/403255609

(Please note that this is a fully automated comment.)

@Blackbaud-BobbyEarl
Copy link

@blackbaud-sky-savage retry

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 2bdf31c
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/403280269

(Please note that this is a fully automated comment.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants