Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

made ariaLabel/title an input for tokens #1824

Merged
merged 6 commits into from
Jul 16, 2018

Conversation

blackbaud-conorwright
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 13, 2018

Codecov Report

Merging #1824 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1824   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         410      410           
  Lines        8574     8580    +6     
  Branches     1260     1263    +3     
=======================================
+ Hits         8573     8579    +6     
  Misses          1        1
Impacted Files Coverage Δ
src/modules/tokens/token.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a4e94...506f561. Read the comment docs.

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this looks great!

Now that we have a way to set the token component's ARIA label, would you mind adjusting the filter and list filter components' usage of token to satisfy these issues?
#1001
#1185

@blackbaud-conorwright
Copy link
Contributor Author

done

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 7182334 into master Jul 16, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the fix-tokens-input-arialabel branch July 16, 2018 22:01
@blackbaud-johnly
Copy link
Contributor

Created #1848 to document new input.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants