Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Visual tests should fail on protractor 199 #1830

Merged
merged 4 commits into from
Jul 18, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

A pull request was merged into master even though it failed during the visual step (the step returned with a zero exit code). This should catch those errors.

See: https://api.travis-ci.org/v3/job/404683473/log.txt

@codecov-io
Copy link

codecov-io commented Jul 17, 2018

Codecov Report

Merging #1830 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1830   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         410      410           
  Lines        8589     8589           
  Branches     1269     1269           
=======================================
  Hits         8588     8588           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5088a48...3f744e5. Read the comment docs.

@Blackbaud-BobbyEarl
Copy link

Blackbaud-BobbyEarl commented Jul 18, 2018

Leaving a comment. This functionality was purposefully added to skyux2, then to builder, then to here. The use-case, unfortunately, wasn't detailed very well. I'm fine removing this now as it does appear to be masking legitimate failures, but it's something we should keep an eye on before removing it from builder.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit bd9c290 into master Jul 18, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the fail-on-protractor-199 branch July 18, 2018 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants