This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Icon component #1834
Closed
Icon component #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we accommodate multiple classes. For example, how would you do |
|
Created #1831 to document this component. |
Codecov Report
@@ Coverage Diff @@
## master #1834 +/- ##
==========================================
+ Coverage 99.98% 99.98% +<.01%
==========================================
Files 410 412 +2
Lines 8589 8600 +11
Branches 1269 1269
==========================================
+ Hits 8588 8599 +11
Misses 1 1
Continue to review full report at Codecov.
|
|
@Blackbaud-SteveBrush Should I still review this or are we closing it in favor of #1842 ? |
|
Closing in favor of: #1846 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original contribution: #1828
Resolves: #1674
(We still need to replace all instances of
fa-for other modules. #1833)