Fix issues with tabs that are activated via an ngIf #1887
Conversation
… to better register changes after initial load of tabset
Codecov Report
@@ Coverage Diff @@
## master #1887 +/- ##
======================================
Coverage 100% 100%
======================================
Files 414 414
Lines 8642 8643 +1
Branches 1279 1279
======================================
+ Hits 8642 8643 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1887 +/- ##
======================================
Coverage 100% 100%
======================================
Files 414 414
Lines 8663 8664 +1
Branches 1282 1282
======================================
+ Hits 8663 8664 +1
Continue to review full report at Codecov.
|
src/modules/tabs/tabset.component.ts
Outdated
| @@ -95,8 +95,10 @@ export class SkyTabsetComponent | |||
| // initialize each tab's index. (in case tabs are instantiated out of order) | |||
| this.tabs.forEach(item => item.initializeTabIndex()); | |||
| this.tabs.changes.subscribe((change: QueryList<SkyTabComponent>) => { | |||
| change.filter(tab => tab.tabIndex === undefined) | |||
| .forEach(item => item.initializeTabIndex()); | |||
| this.tabsetService.tabs.subscribe(currentTabs => { | |||
There was a problem hiding this comment.
Why do we need a nested subscription here? Could we get what we need by just listening to the service?
There was a problem hiding this comment.
Because we need the first subscription here to know what has changed in the DOM . We then need the second subscription to know what the service currently recognizes. We then filter the DOM tabs to find only the ones that the service doesn't know about and then we initialize those in order to have the service recognize them.
I'm happy you asked the question though as I wasn't having the inner subscription close after the first output so it would have potentially led to memory issues.
There was a problem hiding this comment.
👍 sounds good. nice catch on the inner sub.
Blackbaud-AlexKingman
added
Status: Ready to merge
and removed
Status: Ready for review
labels
#1883