This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 65
Contrib > Checklist "show selected items" #1900
Merged
Blackbaud-AlexKingman
merged 16 commits into
master
from
contrib-checklist-show-selected-items
Aug 16, 2018
Merged
Contrib > Checklist "show selected items" #1900
Blackbaud-AlexKingman
merged 16 commits into
master
from
contrib-checklist-show-selected-items
Aug 16, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-AlexKingman
changed the title
Contrib checklist show selected items
Contrib > Checklist "show selected items"
Aug 14, 2018
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
======================================
Coverage 100% 100%
======================================
Files 414 415 +1
Lines 8678 8743 +65
Branches 1285 1292 +7
======================================
+ Hits 8678 8743 +65
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
approved these changes
Aug 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI looks ok to me, matches UX1 to the extent possible.
Blackbaud-SteveBrush
added
Status: Ready to merge
and removed
Status: Ready for review
labels
Aug 16, 2018
Blackbaud-AlexKingman
deleted the
contrib-checklist-show-selected-items
branch
August 16, 2018 19:10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376
Original contribution: #1891