Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Contrib > Checklist "show selected items" #1900

Merged
merged 16 commits into from
Aug 16, 2018

Conversation

Blackbaud-AlexKingman
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman commented Aug 14, 2018

Fixes #376

Original contribution: #1891

@codecov-io
Copy link

codecov-io commented Aug 14, 2018

Codecov Report

Merging #1900 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1900   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         414     415    +1     
  Lines        8678    8743   +65     
  Branches     1285    1292    +7     
======================================
+ Hits         8678    8743   +65
Impacted Files Coverage Δ
src/modules/list/state/toolbar/actions.ts 100% <100%> (ø) ⬆️
...modules/list/state/toolbar/toolbar.orchestrator.ts 100% <100%> (ø) ⬆️
src/modules/search/search.component.ts 100% <100%> (ø) ⬆️
src/modules/list-toolbar/list-toolbar.component.ts 100% <100%> (ø) ⬆️
src/modules/filter/filter-button.component.ts 100% <100%> (ø) ⬆️
src/modules/list/list-data-request.model.ts 100% <100%> (ø) ⬆️
...st-view-checklist/list-view-checklist.component.ts 100% <100%> (ø) ⬆️
src/modules/list/state/toolbar/disable.action.ts 100% <100%> (ø)
src/modules/list/state/toolbar/toolbar.model.ts 100% <100%> (ø) ⬆️
src/modules/list/list.component.ts 100% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b84e1b8...9089b93. Read the comment docs.

Copy link
Contributor

@Blackbaud-ToddRoberts Blackbaud-ToddRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks ok to me, matches UX1 to the extent possible.

@Blackbaud-AlexKingman Blackbaud-AlexKingman merged commit 89cd8cd into master Aug 16, 2018
@Blackbaud-AlexKingman Blackbaud-AlexKingman deleted the contrib-checklist-show-selected-items branch August 16, 2018 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants