Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Consistent styles for select field #1913

Merged
merged 9 commits into from
Aug 17, 2018

Conversation

Blackbaud-AlexKingman
Copy link
Contributor

Fixes #1242

@codecov-io
Copy link

codecov-io commented Aug 15, 2018

Codecov Report

Merging #1913 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1913   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         415     415           
  Lines        8746    8746           
  Branches     1292    1292           
======================================
  Hits         8746    8746

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90bc90...5cb18ee. Read the comment docs.

@Blackbaud-AlexKingman
Copy link
Contributor Author

Here's what this looks like on various browsers:

Edge
win-edge

Internet Explorer 11
win-ie11

Chrome (Windows)
mac-safari

Safari (Mac)
screen shot 2018-08-16 at 2 13 59 pm

Firefox (Mac)
mac-ff

Chrome (Mac)
mac-chrome

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch self-assigned this Aug 16, 2018
Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Blackbaud-ToddRoberts - does this look ok to you?

@Blackbaud-ToddRoberts
Copy link
Contributor

Blackbaud-ToddRoberts commented Aug 16, 2018

Having a couple other designers look at this as well since we were discussing Select styling recently.

@Blackbaud-ToddRoberts
Copy link
Contributor

Is there any accessibility impact here?

@Blackbaud-ToddRoberts
Copy link
Contributor

Generally the style is good. I can't tell what the spacing is between the text and the icon - can we ensure it's 10px as it is for Dropdown?

@Blackbaud-AlexKingman
Copy link
Contributor Author

@Blackbaud-ToddRoberts took a few tweaks, but the padding is now 10px for all browsers above.

@Blackbaud-AlexKingman
Copy link
Contributor Author

Also, @Blackbaud-ToddRoberts re:accessibility > Great question. I compared this change with the prior state using JAWS screen reader, and its the same experience. It doesn't affect any aria labels or key strokes, since the change is limited to CSS only. JAWS still sees it as a combo box. I think we're good to go here.

@Blackbaud-AlexKingman Blackbaud-AlexKingman merged commit f8359c6 into master Aug 17, 2018
@Blackbaud-AlexKingman Blackbaud-AlexKingman deleted the 1242-consistent-select-styles branch August 17, 2018 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants