This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…skyux2 into fix-sort-button-label
Codecov Report
@@ Coverage Diff @@
## master #1915 +/- ##
========================================
Coverage ? 100%
========================================
Files ? 415
Lines ? 8746
Branches ? 1292
========================================
Hits ? 8746
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
Added #1916 to document new ARIA property. |
…skyux2 into contrib-fix-sort-button-label
LGTM. |
Blackbaud-AlexKingman
approved these changes
Aug 16, 2018
Blackbaud-AlexKingman
added
Status: Ready to merge
and removed
Status: Ready for review
labels
Aug 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done by @Blackbaud-JackMcElhinney
Title was not being set on button with attr prefix. Passed the label as well and created test case to make sure both were set properly.
Resolves: #1191, resolves #1192, resolves #1193