Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Contrib > fix sort button label #1915

Merged
merged 12 commits into from
Aug 17, 2018

Conversation

blackbaud-conorwright
Copy link
Contributor

Work done by @Blackbaud-JackMcElhinney

Title was not being set on button with attr prefix. Passed the label as well and created test case to make sure both were set properly.

Resolves: #1191, resolves #1192, resolves #1193

@codecov-io
Copy link

codecov-io commented Aug 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@8670b15). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1915   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?     415           
  Lines             ?    8746           
  Branches          ?    1292           
========================================
  Hits              ?    8746           
  Misses            ?       0           
  Partials          ?       0
Impacted Files Coverage Δ
src/modules/dropdown/dropdown-menu.component.ts 100% <100%> (ø)
src/modules/sort/sort.component.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8670b15...690da43. Read the comment docs.

@blackbaud-johnly
Copy link
Contributor

Added #1916 to document new ARIA property.

@Blackbaud-AlexKingman
Copy link
Contributor

LGTM.

@Blackbaud-AlexKingman Blackbaud-AlexKingman merged commit b90bc90 into master Aug 17, 2018
@Blackbaud-AlexKingman Blackbaud-AlexKingman deleted the contrib-fix-sort-button-label branch August 17, 2018 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.