Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Contrib > Change components over to using sky-icon #1949

Merged
merged 7 commits into from
Sep 7, 2018

Conversation

blackbaud-conorwright
Copy link
Contributor

@blackbaud-conorwright blackbaud-conorwright commented Aug 28, 2018

Moved over @Remulus2006 's changes

Resolves: #1833

@codecov-io
Copy link

codecov-io commented Aug 31, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4e33160). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1949   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?     424           
  Lines             ?    8994           
  Branches          ?    1328           
========================================
  Hits              ?    8994           
  Misses            ?       0           
  Partials          ?       0
Impacted Files Coverage Δ
...secondary-actions/list-secondary-actions.module.ts 100% <100%> (ø)
.../modules/fileattachments/fileattachments.module.ts 100% <100%> (ø)
src/modules/list-toolbar/list-toolbar.module.ts 100% <100%> (ø)
src/modules/toast/toast.module.ts 100% <100%> (ø)
src/modules/search/search.module.ts 100% <100%> (ø)
src/modules/dropdown/dropdown.module.ts 100% <100%> (ø)
src/modules/tabs/tabs.module.ts 100% <100%> (ø)
src/modules/datepicker/datepicker.module.ts 100% <100%> (ø)
src/modules/modal/modal.module.ts 100% <100%> (ø)
src/modules/autocomplete/autocomplete.module.ts 100% <100%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e33160...8735bd0. Read the comment docs.

Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it!

@blackbaud-conorwright blackbaud-conorwright merged commit 51bdc66 into master Sep 7, 2018
@blackbaud-conorwright blackbaud-conorwright deleted the contrib-changing-to-sky-icon branch September 7, 2018 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants