Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

List View Checklist added word wrapping if no space wrapping available #1951

Merged
merged 1 commit into from
Aug 28, 2018

Conversation

Blackbaud-TrevorBurch
Copy link
Member

Resolves #1770

@@ -5,6 +5,7 @@
display: block;
width: 100%;
cursor: pointer;
word-wrap: break-word;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, could we use overflow-wrap: break-word; instead? Seems that word-wrap is duplicate functionality, but used for legacy browsers: https://stackoverflow.com/questions/17259916/difference-between-overflow-wrap-and-word-break

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overflow-warp is not supported by Edge (original version) and IE11.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked our code base and we use word-wrap in this manner 3 other places.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, overflow-wrap is aliased as word-wrap for Edge and IE. https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap#Browser_compatibility

Thanks for the clarification!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, overflow-wrap is aliased as word-wrap for Edge and IE. https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap#Browser_compatibility

Thanks for the clarification!

@codecov-io
Copy link

codecov-io commented Aug 28, 2018

Codecov Report

Merging #1951 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1951   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         416     416           
  Lines        8760    8760           
  Branches     1292    1292           
======================================
  Hits         8760    8760

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90d336c...94be0d4. Read the comment docs.

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch merged commit c54fc1d into master Aug 28, 2018
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch deleted the 1770-select-field-wrapping branch August 28, 2018 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants