-
Notifications
You must be signed in to change notification settings - Fork 65
List View Checklist added word wrapping if no space wrapping available #1951
Conversation
@@ -5,6 +5,7 @@ | |||
display: block; | |||
width: 100%; | |||
cursor: pointer; | |||
word-wrap: break-word; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, could we use overflow-wrap: break-word;
instead? Seems that word-wrap
is duplicate functionality, but used for legacy browsers: https://stackoverflow.com/questions/17259916/difference-between-overflow-wrap-and-word-break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overflow-warp is not supported by Edge (original version) and IE11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked our code base and we use word-wrap
in this manner 3 other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct, overflow-wrap
is aliased as word-wrap
for Edge and IE. https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap#Browser_compatibility
Thanks for the clarification!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct, overflow-wrap
is aliased as word-wrap
for Edge and IE. https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap#Browser_compatibility
Thanks for the clarification!
Codecov Report
@@ Coverage Diff @@
## master #1951 +/- ##
======================================
Coverage 100% 100%
======================================
Files 416 416
Lines 8760 8760
Branches 1292 1292
======================================
Hits 8760 8760 Continue to review full report at Codecov.
|
Resolves #1770