Added handling for disabling iframes when a flyout is being dragged #1952
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1952 +/- ##
======================================
Coverage 100% 100%
======================================
Files 424 424
Lines 8968 8974 +6
Branches 1326 1327 +1
======================================
+ Hits 8968 8974 +6
Continue to review full report at Codecov.
|
| @@ -37,4 +37,15 @@ export class SkyFlyoutAdapterService { | |||
| this.renderer.addClass(header.nativeElement, 'sky-flyout-help-shim'); | |||
| } | |||
| } | |||
|
|
|||
| public toggleIframePointerEvents(enable: boolean): void { | |||
There was a problem hiding this comment.
Should we call this enableIframePointerEvents to be more specific?
There was a problem hiding this comment.
I don't think so. As enable is a flag that enables or disables. I feel like toggle is more specific as it shows that you can toggle on or off. enable sounds to me like it is always turning it on
There was a problem hiding this comment.
Hmm... not sure I agree there
https://media.giphy.com/media/EVbEdEW3kuu0o/giphy.gif
But since you've been a good sport with all my other PR comments today, I'll let this one slide :) The code is sound 👍
Blackbaud-TrevorBurch
assigned Blackbaud-AlexKingman and unassigned Blackbaud-TrevorBurch
Blackbaud-AlexKingman
assigned Blackbaud-TrevorBurch and unassigned Blackbaud-AlexKingman
Blackbaud-TrevorBurch
added
Status: Ready to merge
and removed
Status: Ready for review
labels
Original code basis from @Blackbaud-StewartStephens
Resolves #1794