Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Made fluid grid column inputs responsive. #1962

Merged
merged 7 commits into from
Sep 7, 2018

Conversation

Blackbaud-TrevorBurch
Copy link
Member

Resolves #1957

@Blackbaud-TrevorBurch
Copy link
Member Author

@Blackbaud-BobbyEarl do we need to make a PR and port this into Stache too? I noticed that the code that you linked to on the issue was actually in Stache.

@Blackbaud-BobbyEarl
Copy link

hmm, good question @Blackbaud-TrevorBurch. I didn't realize both still existed. Would it be possible to deprecate the Stache one (or at least drop in this one)? @Blackbaud-LindseyRix @Blackbaud-BrandonJones

@Blackbaud-BrandonJones
Copy link
Contributor

Blackbaud-BrandonJones commented Sep 5, 2018

@Blackbaud-BobbyEarl I will create an issue to look into converting to using this fluid grid.

https://github.com/blackbaud/stache2/issues/526

@lindsey-rix
Copy link
Member

As long as we still support the stache component, I'm fine with this. We just can't deprecate our component because sites are using it.

@codecov-io
Copy link

codecov-io commented Sep 5, 2018

Codecov Report

Merging #1962 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1962   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         425     425           
  Lines        9122    9125    +3     
  Branches     1349    1350    +1     
======================================
+ Hits         9122    9125    +3
Impacted Files Coverage Δ
src/modules/fluid-grid/column.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d820c...869eac8. Read the comment docs.

Copy link
Contributor

@blackbaud-conorwright blackbaud-conorwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a minor style issue. Otherwise looks good 😄

@@ -4,24 +4,26 @@ import {
expect
} from '@blackbaud/skyux-builder/runtime/testing/browser';

import { ColumnTestComponent } from './fixtures/column.component.fixture';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imports should be on separate lines(barrels):

import {
  ColumnTestComponent
} from './fixtures/column.component.fixture';

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch merged commit 4e33160 into master Sep 7, 2018
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch deleted the 1957-fluid-grid-input-responsiveness branch September 7, 2018 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants