-
Notifications
You must be signed in to change notification settings - Fork 65
Made fluid grid column inputs responsive. #1962
Made fluid grid column inputs responsive. #1962
Conversation
@Blackbaud-BobbyEarl do we need to make a PR and port this into Stache too? I noticed that the code that you linked to on the issue was actually in Stache. |
hmm, good question @Blackbaud-TrevorBurch. I didn't realize both still existed. Would it be possible to deprecate the Stache one (or at least drop in this one)? @Blackbaud-LindseyRix @Blackbaud-BrandonJones |
@Blackbaud-BobbyEarl I will create an issue to look into converting to using this fluid grid. https://github.com/blackbaud/stache2/issues/526 |
As long as we still support the stache component, I'm fine with this. We just can't deprecate our component because sites are using it. |
Codecov Report
@@ Coverage Diff @@
## master #1962 +/- ##
======================================
Coverage 100% 100%
======================================
Files 425 425
Lines 9122 9125 +3
Branches 1349 1350 +1
======================================
+ Hits 9122 9125 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a minor style issue. Otherwise looks good 😄
@@ -4,24 +4,26 @@ import { | |||
expect | |||
} from '@blackbaud/skyux-builder/runtime/testing/browser'; | |||
|
|||
import { ColumnTestComponent } from './fixtures/column.component.fixture'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imports should be on separate lines(barrels):
import {
ColumnTestComponent
} from './fixtures/column.component.fixture';
…7-fluid-grid-input-responsiveness
Resolves #1957