This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
disabled aria-controls when the target has not been drawn #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1968 +/- ##
======================================
Coverage 100% 100%
======================================
Files 425 425
Lines 9139 9144 +5
Branches 1350 1352 +2
======================================
+ Hits 9139 9144 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@blackbaud-conorwright Could we get a unit test to prove this works?
…ithub.com:blackbaud/skyux2 into fix-inline-filter-button-aria-controls-unexpanded
|
@Blackbaud-SteveBrush Sorry I wasn't finished yet. There was a unit test that checked it but didn't expect the result so I updated that. I also added a visual test with the inline filters expanded and not so that the accessibility testing will catch if it happens again |
Blackbaud-SteveBrush
approved these changes
Sep 7, 2018
blackbaud-conorwright
deleted the
fix-inline-filter-button-aria-controls-unexpanded
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.20.2Fixes an accessibility issue where the inline filters are not expanded, but are referenced by the inline filter button in the aria-controls attribute.