Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Grid: column resize #1973

Merged
merged 32 commits into from
Sep 18, 2018
Merged

Conversation

Blackbaud-AlexKingman
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman commented Sep 10, 2018

Resolves #317

@blackbaud-johnly
Copy link
Contributor

Created #1974 to document the new columnWidthChange event and handle any other doc changes necessary for this work.

# Conflicts:
#	src/modules/grid/grid.component.html
#	src/modules/grid/grid.module.ts
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I would have @blackbaud-conorwright look at the ARIA stuff, since he is more experienced with it.

src/modules/grid/fixtures/grid.component.fixture.html Outdated Show resolved Hide resolved
src/modules/grid/grid-adapter.service.ts Outdated Show resolved Hide resolved
src/modules/grid/grid.component.html Outdated Show resolved Hide resolved
Copy link
Contributor

@blackbaud-conorwright blackbaud-conorwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from yesterday that I didn't get a chance to try locally

.gitignore Show resolved Hide resolved
tabindex="-1"
(mousedown)="onMouseDownResizeCol($event)">
</span>
<input
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So unfortunately this is also going to need the role of separator. It is also going to need to be visibly focused on the page. I go around this for flyout resizing by making them the same element. and that may work out here too.

Sorry, I haven't been able to check it manually. I'm having issues serving right now and I'm not sure why yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've updated the <input> to have the role of separator, and be focusable. Let me know if you notice anything else!

Copy link
Contributor

@blackbaud-conorwright blackbaud-conorwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants