-
Notifications
You must be signed in to change notification settings - Fork 65
Grid: column resize #1973
Grid: column resize #1973
Conversation
…ecessarily setting table width.
Created #1974 to document the new |
# Conflicts: # src/modules/grid/grid.component.html # src/modules/grid/grid.module.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I would have @blackbaud-conorwright look at the ARIA stuff, since he is more experienced with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment from yesterday that I didn't get a chance to try locally
src/modules/grid/grid.component.html
Outdated
tabindex="-1" | ||
(mousedown)="onMouseDownResizeCol($event)"> | ||
</span> | ||
<input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So unfortunately this is also going to need the role of separator. It is also going to need to be visibly focused on the page. I go around this for flyout resizing by making them the same element. and that may work out here too.
Sorry, I haven't been able to check it manually. I'm having issues serving right now and I'm not sure why yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've updated the <input>
to have the role of separator, and be focusable. Let me know if you notice anything else!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 😄
…lackbaud/skyux2 into 317-drag-to-resize-grid-header
Resolves #317