Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Fixed radio buttons permanently being checked when outside of a group #1982

Merged
merged 2 commits into from
Sep 12, 2018

Conversation

blackbaud-conorwright
Copy link
Contributor

@blackbaud-conorwright blackbaud-conorwright commented Sep 12, 2018

Resolves: #1981

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for putting in better coverage around the radios too!

🚢 🇮🇹

@codecov-io
Copy link

Codecov Report

Merging #1982 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1982   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         422     422           
  Lines        8994    8993    -1     
  Branches     1333    1332    -1     
======================================
- Hits         8994    8993    -1
Impacted Files Coverage Δ
src/modules/radio/radio.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 205a778...501984b. Read the comment docs.

@blackbaud-conorwright blackbaud-conorwright merged commit 1fbee2c into master Sep 12, 2018
@blackbaud-conorwright blackbaud-conorwright deleted the fix-radio-buttons-checked branch September 12, 2018 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants