Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Grid > fixed several resize column bugs #2039

Merged
merged 17 commits into from
Oct 3, 2018

Conversation

Blackbaud-AlexKingman
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman commented Sep 28, 2018

  1. Fixed resize handle from showing up too far to the right. Resolves Grid resize bar is too far to the right when columns are larger than width of grid's parent #2035
  2. Fixed grid overflow / scrollbar issue. Resolves Grid > resize handle causes table to show scrollbar. #2031
  3. Fixed firefox click event not firing issue. Resolves Grid resize > Firefox not releasing resize handle #2038

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question...

@@ -17,6 +17,7 @@
margin: 0;
font-size: $sky-font-size-base;
min-width: 100%;
overflow: hidden;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be super dangerous; for example, this style could clip an absolutely positioned element in the cell if its position was slightly outside the table's boundaries. Is there a different way to accomplish this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple ideas:

  1. Make the last resize handle half the width. It would be a smaller target, but it would never cause an overflow.
  2. Never allow the last column to be resized. This solution just gets rid of that last resize handle all together.

I think I like #1 the best? What do you think?

@Blackbaud-SteveBrush Blackbaud-SteveBrush self-assigned this Oct 3, 2018
@codecov-io
Copy link

codecov-io commented Oct 3, 2018

Codecov Report

Merging #2039 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2039      +/-   ##
==========================================
+ Coverage   99.93%   99.93%   +<.01%     
==========================================
  Files         391      391              
  Lines        7749     7755       +6     
  Branches     1121     1124       +3     
==========================================
+ Hits         7744     7750       +6     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/grid/grid.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0290181...c809983. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants