-
Notifications
You must be signed in to change notification settings - Fork 65
Grid > fixed several resize column bugs #2039
Conversation
Blackbaud-AlexKingman
commented
Sep 28, 2018
•
edited
Loading
edited
- Fixed resize handle from showing up too far to the right. Resolves Grid resize bar is too far to the right when columns are larger than width of grid's parent #2035
- Fixed grid overflow / scrollbar issue. Resolves Grid > resize handle causes table to show scrollbar. #2031
- Fixed firefox click event not firing issue. Resolves Grid resize > Firefox not releasing resize handle #2038
… fixed resize handle from showing up too far to the right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question...
src/modules/grid/grid.component.scss
Outdated
@@ -17,6 +17,7 @@ | |||
margin: 0; | |||
font-size: $sky-font-size-base; | |||
min-width: 100%; | |||
overflow: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be super dangerous; for example, this style could clip an absolutely positioned element in the cell if its position was slightly outside the table's boundaries. Is there a different way to accomplish this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple ideas:
- Make the last resize handle half the width. It would be a smaller target, but it would never cause an overflow.
- Never allow the last column to be resized. This solution just gets rid of that last resize handle all together.
I think I like #1 the best? What do you think?
… table while in scroll mode
Codecov Report
@@ Coverage Diff @@
## master #2039 +/- ##
==========================================
+ Coverage 99.93% 99.93% +<.01%
==========================================
Files 391 391
Lines 7749 7755 +6
Branches 1121 1124 +3
==========================================
+ Hits 7744 7750 +6
Misses 5 5
Continue to review full report at Codecov.
|