This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Checklist view #344
Merged
Checklist view #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: - default toolbar to toolbarType=“search” when using checklist view - remove category reference for now (doesn’t do anything at this point) - add sky-btn-link class for styles for select all and clear all - unit test everything - document sky-list and list-view-checklist - visual test checklist
Also: - added styles for btn-link, btn-default, and btn-link-inline - used resources instead of hardcoded strings
TODO: - docs updates for checklist, list, and toolbar - visual tests for checklist view
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
======================================
Coverage 100% 100%
======================================
Files 202 213 +11
Lines 3107 3280 +173
Branches 322 344 +22
======================================
+ Hits 3107 3280 +173
Continue to review full report at Codecov.
|
Blackbaud-PatrickOFriel
requested review from
Blackbaud-BobbyEarl,
Blackbaud-PaulCrowder and
Blackbaud-TerryHelems
Blackbaud-BobbyEarl
approved these changes
Feb 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#340 #112