Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Add column template and list documentation to grids #369

Merged
merged 3 commits into from
Feb 22, 2017
Merged

Add column template and list documentation to grids #369

merged 3 commits into from
Feb 22, 2017

Conversation

Blackbaud-PatrickOFriel
Copy link
Contributor

@Blackbaud-PatrickOFriel Blackbaud-PatrickOFriel commented Feb 21, 2017 •
edited
Loading

@codecov-io
Copy link

codecov-io commented Feb 21, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@31a4a9f). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master   #369   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?    213           
  Lines             ?   3291           
  Branches          ?    344           
=======================================
  Hits              ?   3291           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a4a9f...8aefb49. Read the comment docs.

Blackbaud-BobbyEarl
Blackbaud-BobbyEarl reviewed Feb 21, 2017
View reviewed changes
src/app/components/grid/index.html Outdated
@@ -1,6 +1,6 @@
<sky-demo-page title="Grid">
<sky-demo-page-summary>
This grid component displays a SKY UX-themed grid of data. The grid should contain <code>sky-grid-column</code> components which specify column information.
This grid component displays a SKY UX-themed grid of data. The grid should contain <code>sky-grid-column</code> components which specify column information. The <code>sky-grid</code> component can be used as a view of a searchable and pagable list component when used within the <a routerLink="../list-view-grid">sky-list</a> component.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pagable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with paging better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or with pagination?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blackbaud-johnly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow response. I'd go with "a searchable, paginated list component"? ... If that doesn't work, I'd change "pagable" to "pageable." But I think the first suggestion is better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with ', paginated list'

@Blackbaud-PatrickOFriel Blackbaud-PatrickOFriel merged commit 2fa8a79 into master Feb 22, 2017
@Blackbaud-BobbyEarl Blackbaud-BobbyEarl deleted the grid-documentation branch March 1, 2017 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl Blackbaud-BobbyEarl left review comments

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder Awaiting requested review from Blackbaud-PaulCrowder

@blackbaud-johnly blackbaud-johnly Awaiting requested review from blackbaud-johnly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Blackbaud-PatrickOFriel @codecov-io @Blackbaud-BobbyEarl @blackbaud-johnly