Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Added background color to the main button on a dropdown #490

Conversation

Blackbaud-TrevorBurch
Copy link
Member

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: cba601a
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/211488877

(Please note that this is a fully automated comment.)

@Blackbaud-PatrickOFriel
Copy link
Contributor

@blackbaud-sky-savage retry

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: cba601a
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/211507262

(Please note that this is a fully automated comment.)

@Blackbaud-PatrickOFriel
Copy link
Contributor

@Blackbaud-TrevorBurch Looks like some of our visual tests failed because navbar was relying on the dropdown button to inherit the background color. Want to take a look at fixing that?

@Blackbaud-TrevorBurch
Copy link
Member Author

Sure. I'll give it a look in the morning.

@codecov-io
Copy link

codecov-io commented Mar 16, 2017

Codecov Report

Merging #490 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #490   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         244    244           
  Lines        3773   3773           
  Branches      387    387           
=====================================
  Hits         3773   3773

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6fe88...52f209d. Read the comment docs.

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 876e2b0
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/211765887

(Please note that this is a fully automated comment.)

@Blackbaud-TrevorBurch
Copy link
Member Author

I've fixed the issue surrounding the navbar.

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 52f209d
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/213409757

(Please note that this is a fully automated comment.)

@Blackbaud-PatrickOFriel Blackbaud-PatrickOFriel merged commit adb3ece into blackbaud:master Mar 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants