This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Datepicker calendar #608
Merged
Datepicker calendar #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things to think about: - Instead of using Javascript Date, think about using skyDate class with day, month, year properties. - Get everything working with simplest case
TODO: - Add styles for month picker and year picker - clean up styles - verify startingDay - verify minDate, maxDate - clean up code - unit tests - visual tests - remove demo (only show demo for input)
TODO: - create dateObject interface - unit tests
TODO: - set active function tests - edge case tests - rudimentary documentation - remove docs from main component page until connected with input - visual tests - accessibility
TODO: - fix tests for year picker - add a bunch of tests for keyboard functionality - initial docs - remove docs from component list - visual tests
Blackbaud-PatrickOFriel
requested review from
Blackbaud-BobbyEarl,
Blackbaud-PaulCrowder and
Blackbaud-ToddRoberts
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
======================================
Coverage 100% 100%
======================================
Files 269 277 +8
Lines 4298 4629 +331
Branches 459 511 +52
======================================
+ Hits 4298 4629 +331
Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
approved these changes
Apr 26, 2017
|
I'll get Todd's style changes in this afternoon and merge it in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calendar component for #141. Temporary docs aren't in the main components page, but can be found at components/datepicker