This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 65
Tabs keyboard support #840
Closed
Blackbaud-SandhyaRajasabeson
wants to merge
19
commits into
blackbaud:rc-ng4-upgrade
from
Blackbaud-SandhyaRajasabeson:tabs-keyboard-support
Closed
Tabs keyboard support #840
Blackbaud-SandhyaRajasabeson
wants to merge
19
commits into
blackbaud:rc-ng4-upgrade
from
Blackbaud-SandhyaRajasabeson:tabs-keyboard-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty Docs appsettings property
* update builder version for skyux documentation * pass string to expandmode * Update container for component search * Use class instead of inline styles * work on text expand firefox bug * continue work on firefox transitions * Adjust text expand animation for firefox * Update tests for new text expand animation * Fix tslint errors
* Only set page number on search when paging exists * Add tests for search paging bug
* Adding Autonumeric * Fixed Test * Changed name from SkyAutonumeric to SkyNumeric * Changing formatting * Changes per comments, OptionsObject used * Updated wording
* created email validation ts * email validation scss * email validation code and test start * email validator testing files * last lint error fixed * component page summary * error message/red halo doesn't show until lost focus * Changes from Patrick * Changes from Patrick (took care of errors) * added form control for demo input box consistency * Fixed lint errors * Added sky-form-control to demo/removed onInit from module code * Lint errors
# CHANGELOG.md # package.json # src/core.ts # src/modules/avatar/avatar.component.ts # src/modules/timepicker/timepicker.component.ts
Blackbaud-PatrickOFriel
requested review from
Blackbaud-PatrickOFriel and
Blackbaud-ToddRoberts
June 28, 2017 13:47
Blackbaud-ToddRoberts
approved these changes
Jun 28, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
Closing in favor of #843 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#188