Inline help #874

Blackbaud-SandhyaRajasabeson · 2017-07-07T20:46:05Z

* Package upgrades * Fixed tslint issues TODO: - fix search and sort tests * Update package.json * Fix context replacement plugin * Remove forkCheckerPlugin from webpack * Fix contentBase error * fix sort test add logging back to karma.conf * Fix search tests TODO: - fix code coverage gaps * Fix lint errors * ignore new istanbul quirks * update rollup to include platform browser name * Angular 4 Upgrade > Additional Edits (#702) * Allow for proper nesting for getting data for lists and grids (#671) * Changed the list helper getData function to set the result to null if the final part was undefined so that nesting works correctly. * Added unit tests * updates skyux2 docs to use stache2 (#681) * home page and pulling in stache things * removed need for title service * components demo component using stache * removed change to package json * removed unecessary method * updating learn page and removing overview folder * spacing issue fixed * Convert reference topics to Stache 2 * refactored all the tutorial section * Doc tweaks for Stache 2. * Final doc tweaks before merge * versioned without vs * Update builder version (#693) * Update builder version * Remove unneeded packages * Update full page modal header sizes (#679) * Update full page modal header sizes * Update full screen modal screenshots * Travis build 1313 pushed to skyux2 [ci skip] * Update wait component z-index (#684) * Travis build 1316 pushed to skyux2 [ci skip] * Adjust padding for closeable tab (#685) To account for built-in padding in the close button. * Travis build 1318 pushed to skyux2 [ci skip] * Handle styles for filedrop when links are not allowed (#686) * Travis build 1325 pushed to skyux2 [ci skip] * Add cancel button to wizard docs and update modal button spacing (#689) * Added yarn lock * Cleaned files based on lint rules * Removed unused comments * Updated excluded source maps * Updated version of tslint * Fixed linting errors * Reverting version of browserstack-local * Update to connect to browserstack properly Use browserstack service instead of binary. Also fix error with axe. * Fix variable name * Bump tests * Remove unit tests to test visual tests on their own * Actually remove unit tests for ci to run visuals * Use one parallel test * Add error logs for wdio * Add unit tests back * Log build number for visual tests on ci * Add logs to see what's going on * Try to use travis browsersrtack addon * try using travis browserstack again * remove old browserstack stuff * Use encrypted variables with travis browserstack * Add more logging and use different travis encryption * Add more logging * Add more logging to webdriver * Add more logging * Tweak visual server settings * try running visual test webpack dev server * set noInfo to false * update host for dev server * use local browserstack wdio * see what error occurs when using nonsense text * Add env variables back * Add more wdio configuration * Use browserstack binary * Remove extra options from visual-server * Remove unneeded logging * make log level silent * Run entire test suite Revert normalize-sass to original version * use old wdio versions for testing * Add connection retry settings * whitespace bump * Re update wdio packages * Remove unneeded logging * Remove parallel testing * Use sudo required for builds * remove reference to browserstack-local * See how 25 parallel tests run * Use 3 parallel visual tests and latest stable version of node * Update visual-server.js * Update travis-script.sh * Updated formatting * More adjustments * Added console logs * Added error checking * Added logs * Reduced number of instances * Updated logs * Updated log * Updated logs * Updates * Removed console logs * Changed styles for visual test * Updated wait test * Updates to private variables * Updated list toolbar default * Updated public variable * Updating selenium version * Fixed bugs with templates * Cleaned up unnecessary changes * Updated version of stache * Upped max instances * Up wait for timeout * Add some waitForVisibles in alert and action button * Added path resolves * Builder visual (#791) * Add start of visual tests * continue working on skyux builder visual tests * more work on getting builder visual tests to work * More work around visual tests * fix package name typo * Update import paths for visual test spa * Add normalize-scss to package.json * Fix moment import to work with rollup This way works also with copying the dist folder to node_modules * fix tile strangeness * start scripts for visual test setup * Continue protractor work * start of visual test command * duplicate a bit of work to get protractor ready to go * Get protractor to go to a page * Add first pass at image comparison TODO: - do not fail when image does not exist * Continue pixdiff work * Work on thresholds * Screenshots working with alert visual test TODO: - create compare screenshot wrapper function - get action button tests - get working with browserstack - get working with browserstack and TravisCI * Add wrapper function for visual tests TODO: - accessibility testing - more elegant way to change size - use browserstack - travis commands * Add checkAccessibility TODO: - browserstack configuration - get working in travis * Break out local visual test conf file * Add content for ci visual tests TODO: - switch configuration file used based on argue - test using browserstack - add the rest of the tests - get TravisCI implementations working * Allow visual tests to change config based on command line * Browserstack tests working * fix browserstack local visual tests TODO: - get other tests moved over - test using browserstack - get TravisCI integration working - remove all traces of wdio and old tests * Add avatar visual test * Add button visual test * Add visual tests for card, checkbox, and chevron * Add datepicker, definition list, and dropdown visual tests * Add error, file drop, and filter visual tests * Add visual tests for grid, key-info, label, list-secondary-actions, list-view-checklist, and modals * add visual tests for navbar * Add page summary visual tests * Add visual tests for paging, radio, repeater * Add visual tests for search, sort, tabs * Add visual tests for text-expand, text-expand-repeater, tiles * Finsih visual tests * Updated visual tests * Update ci tests * fix package.json conflict * update other visual test scripts * Tweak scripts * Fix lint errors * Attempt to add path for skyux/dist/core * Updated stache version * ignore temporary visual test files * Update code coverage * Remove some old visual tests * Remove old visual test artifacts * Remove other old visual test artifacts * remove webdriver packages from package.json * Update documentation for visual tests * Finish documentation for new visual test methodology * Fix visual test selector in new modal tests

* Updated version of stache * Add tsconfig ignore for visual tests * Hit release candidate branch * Fix build errors * Update baseline screenshots in travis scripts * white space bump

* update travis scripts * update visual baseline script

* AppSettings and config files docs. * appSettings and config files docs. * Doc tweaks. * Code sample cleanup * Max height transition (#804) * update builder version for skyux documentation * pass string to expandmode * Update container for component search * Use class instead of inline styles * work on text expand firefox bug * continue work on firefox transitions * Adjust text expand animation for firefox * Update tests for new text expand animation * Fix tslint errors * Update master plunker to point to beta release (#812) * List paging first page (#814) * Only set page number on search when paging exists * Add tests for search paging bug * Updates for beta.32 (#815) * Fix typo for iso8601 * Update dependencies for spa visual tests

* Updates for rc.1 * Tweak changelog styles

* added primary in html class * testing for primary dropdown option * lint errors fixed * documentation fixes from john * documentation changes * changed isPrimary boolean property to buttonStyle string property * fixed test errors

* Updated version of stache * Add tsconfig ignore for visual tests * Hit release candidate branch * Fix build errors * Update baseline screenshots in travis scripts * white space bump * Update package.json * Update package.json * Update package.json * Updated releases * Updated version of stache * Updated version of stache * Added resolve for visual tests * Updated version of stache

* AppSettings and config files docs. * appSettings and config files docs. * Doc tweaks. * Code sample cleanup * Max height transition (#804) * update builder version for skyux documentation * pass string to expandmode * Update container for component search * Use class instead of inline styles * work on text expand firefox bug * continue work on firefox transitions * Adjust text expand animation for firefox * Update tests for new text expand animation * Fix tslint errors * Update master plunker to point to beta release (#812) * List paging first page (#814) * Only set page number on search when paging exists * Add tests for search paging bug * Updates for beta.32 (#815) * Adding Autonumeric Pipe/Module (#792) * Adding Autonumeric * Fixed Test * Changed name from SkyAutonumeric to SkyNumeric * Changing formatting * Changes per comments, OptionsObject used * Updated wording * Email validation (#810) * created email validation ts * email validation scss * email validation code and test start * email validator testing files * last lint error fixed * component page summary * error message/red halo doesn't show until lost focus * Changes from Patrick * Changes from Patrick (took care of errors) * added form control for demo input box consistency * Fixed lint errors * Added sky-form-control to demo/removed onInit from module code * Lint errors * Add note about serving in Windows 10 with IE11 or Edge. (#820) * Add note about serving in Windows 10 with IE11 or Edge. * Rework note based on feedback from Bobby. * Updates for beta.33 (#825) * Fixed linting errors * Update package.json * Dont run skyux build for now * Updated travis script * Readded build * Moved remove commands * Updated version of builder * Updated changelog and version

* Added animation polypill * Moved import to dependencies * Tab keyboard accessibility

* Added animation polypill * Moved import to dependencies

* Adding highlight directive and demo page. * Adding and replacing highlight style. * Use mark element. * Update demo. * Add test for directive. * Update test. * Update highlighter to be case insensitive. * Can't add mark text to innerhtml. * Update tests. * Use mutation observer for dom events. * Reformat test * Update async test. * Mock mutation observer service. * Add extra test. * Adding visual tests. * Add text highlight visual test. * Move mutation service class. * Update event creation in test. * Adding test for mutation observer class. Removing undefined check for IE10. * Disconnect mutation observer on destroy. Add exports. Fix name.

* AppSettings and config files docs. * appSettings and config files docs. * Doc tweaks. * Code sample cleanup * Max height transition (#804) * update builder version for skyux documentation * pass string to expandmode * Update container for component search * Use class instead of inline styles * work on text expand firefox bug * continue work on firefox transitions * Adjust text expand animation for firefox * Update tests for new text expand animation * Fix tslint errors * Update master plunker to point to beta release (#812) * List paging first page (#814) * Only set page number on search when paging exists * Add tests for search paging bug * Updates for beta.32 (#815) * Adding Autonumeric Pipe/Module (#792) * Adding Autonumeric * Fixed Test * Changed name from SkyAutonumeric to SkyNumeric * Changing formatting * Changes per comments, OptionsObject used * Updated wording * Email validation (#810) * created email validation ts * email validation scss * email validation code and test start * email validator testing files * last lint error fixed * component page summary * error message/red halo doesn't show until lost focus * Changes from Patrick * Changes from Patrick (took care of errors) * added form control for demo input box consistency * Fixed lint errors * Added sky-form-control to demo/removed onInit from module code * Lint errors * Add note about serving in Windows 10 with IE11 or Edge. (#820) * Add note about serving in Windows 10 with IE11 or Edge. * Rework note based on feedback from Bobby. * Updates for beta.33 (#825) * Update link (#837) * Fix timepicker demo (#847) * Fix timepicker demo * Remove unneeded whitespace * Update angular to 4.2.5 Also update to latest version of state and skyux-builder * Add ignore around branch

Blackbaud-ToddRoberts · 2017-07-27T15:01:21Z

What is this waiting on now?

Blackbaud-PatrickOFriel · 2017-07-27T15:03:59Z

Hey @Blackbaud-SandhyaRajasabeson when you get the chance can you change the component name/selector to sky-help-inline instead of sky-inline-help. You might also need to get latest from master and fix any conflicts you have.

Blackbaud-SandhyaRajasabeson · 2017-07-27T15:24:36Z

I've already updated it from master and changed all occurrences of inline help to help inline

Blackbaud-PatrickOFriel · 2017-07-27T15:55:26Z

src/app/components/inline-help/inline-help-demo.component.html

+<div>
+    <h2>
+        Giving
+        <sky-inline-help


Looks like its inline-help here instead of help-inline. Did you push your changes @Blackbaud-SandhyaRajasabeson ?

Did it work now?

Blackbaud-PatrickOFriel · 2017-07-27T17:18:19Z

@Blackbaud-SandhyaRajasabeson @Blackbaud-ToddRoberts Looks like the selector and stuff updated, but now its not building properly because you need to use the new color variables instead of the $sky-color-blue.

Blackbaud-ToddRoberts · 2017-07-27T17:29:15Z

should use $sky-text-color-action-primary

Blackbaud-PatrickOFriel · 2017-07-31T14:21:01Z

src/modules/help-inline/help-inline.component.scss

+  background-color: transparent;
+  border: none;
+  display: inline-block;
+  font-size: $sky-font-size-lg;


@Blackbaud-ToddRoberts what should this be instead?

Blackbaud-PatrickOFriel · 2017-07-31T15:46:17Z

src/modules/help-inline/help-inline.component.scss

+.sky-help-inline {
+  margin-left: $sky-padding-half;
+  color: $sky-text-color-action-primary;
+  font-size: 14px;


@Blackbaud-ToddRoberts just wanted to verify that this is an appropriate font-size, it's replacing the $sky-font-size-lg variable that was used previously

should use $sky-font-size-base

Not sure if it needs the left margin, kinda seems hanging out in space. what do you all think?

I'm fine getting rid of the left margin, I'll make both updates

Blackbaud-PatrickOFriel · 2017-08-01T19:07:28Z

Updated with changes @Blackbaud-ToddRoberts, take a look when you get a chance

Blackbaud-ToddRoberts · 2017-08-01T19:35:26Z

Looks good to me

Blackbaud-PatrickOFriel and others added 28 commits June 14, 2017 16:43

Updated version of Stache (#805)

d2caa3a

* Updated version of stache * Add tsconfig ignore for visual tests * Hit release candidate branch * Fix build errors * Update baseline screenshots in travis scripts * white space bump

update travis scripts (#806)

c1d2d85

* update travis scripts * update visual baseline script

Update visual baseline with logging (#807)

10e9cab

Travis build 1644 pushed to skyux2 [ci skip]

863b2bf

Changelog and package updates for rc.0 (#808)

29a7c7a

Updates for rc.1 (#817)

a409fba

* Updates for rc.1 * Tweak changelog styles

Update karma firefox (#818)

4d4d26a

Drop down primary (#819)

95dba71

* added primary in html class * testing for primary dropdown option * lint errors fixed * documentation fixes from john * documentation changes * changed isPrimary boolean property to buttonStyle string property * fixed test errors

Tab keyboard support (#843)

f89531a

* Added animation polypill * Moved import to dependencies * Tab keyboard accessibility

Added animation polyfill (#841)

922c4fb

* Added animation polypill * Moved import to dependencies

Travis build 1744 pushed to skyux2 [ci skip]

6006225

Updates for 2.0.0-rc.3 (#851)

026f708

Updates for 2.0.0-rc.4 (#852)

5407dec

Merge branch 'master' into rc-ng4-upgrade

607fef9

Inline help

34842a3

Merge branch 'rc-ng4-upgrade' into inline-help

10d7ea1

fixed naming discrepencies

cc842b9

Inline help demo and documentation

ec281d7

Trying to add accessibility

5806cdb

testing

9bf825a

2 tests and lint errors

80eed8d

Class discrepancy fix

3636bda

Blackbaud-PatrickOFriel changed the base branch from rc-ng4-upgrade to master July 10, 2017 15:15

Merge branch 'master' into inline-help

6d01ded

Blackbaud-SandhyaRajasabeson added 9 commits July 17, 2017 15:35

Merge branch 'master' into inline-help

39e2d57

Merge branch 'master' into inline-help

570947b

Changed all inline help to help inline

ba23509

Merge branch 'master' into inline-help

7465ff0

Visual test attempt

27af2b0

Visual tests

bd4861e

Merge branch 'master' into inline-help

0f9522a

Merge branch 'master' into inline-help

bb136e0

Merge branch 'master' into inline-help

183c77a

Merge branch 'master' into inline-help

1390ed7

Blackbaud-PatrickOFriel reviewed Jul 27, 2017

View reviewed changes

Merge branch 'master' into inline-help

322fae5

Blackbaud-PatrickOFriel reviewed Jul 31, 2017

View reviewed changes

Blackbaud-SandhyaRajasabeson added 2 commits July 31, 2017 11:42

New bb scss

307a35e

Merge branch 'master' into inline-help

90786d7

Blackbaud-PatrickOFriel reviewed Jul 31, 2017

View reviewed changes

Blackbaud-PatrickOFriel added 2 commits August 1, 2017 15:02

Merge branch 'master' into inline-help

a09e33f

remove margin, add font-size-base

10adcdc

Blackbaud-PatrickOFriel added 2 commits August 2, 2017 09:21

Fix lint errors in visual tests

595fa71

Remove unused import

115dfff

Blackbaud-PatrickOFriel approved these changes Aug 2, 2017

View reviewed changes

Blackbaud-PatrickOFriel merged commit 4bdbb0e into master Aug 2, 2017

Blackbaud-BobbyEarl deleted the inline-help branch August 29, 2017 18:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inline help #874

Inline help #874

Blackbaud-SandhyaRajasabeson commented Jul 7, 2017

Blackbaud-ToddRoberts commented Jul 27, 2017

Blackbaud-PatrickOFriel commented Jul 27, 2017 •

edited

Loading

Blackbaud-SandhyaRajasabeson commented Jul 27, 2017

Blackbaud-PatrickOFriel Jul 27, 2017

Blackbaud-SandhyaRajasabeson Jul 27, 2017

Blackbaud-PatrickOFriel commented Jul 27, 2017

Blackbaud-ToddRoberts commented Jul 27, 2017

Blackbaud-PatrickOFriel Jul 31, 2017

Blackbaud-PatrickOFriel Jul 31, 2017

Blackbaud-ToddRoberts Aug 1, 2017

Blackbaud-ToddRoberts Aug 1, 2017

Blackbaud-PatrickOFriel Aug 1, 2017

Blackbaud-PatrickOFriel commented Aug 1, 2017

Blackbaud-ToddRoberts commented Aug 1, 2017

Inline help #874

Inline help #874

Conversation

Blackbaud-SandhyaRajasabeson commented Jul 7, 2017

Blackbaud-ToddRoberts commented Jul 27, 2017

Blackbaud-PatrickOFriel commented Jul 27, 2017 • edited Loading

Blackbaud-SandhyaRajasabeson commented Jul 27, 2017

Blackbaud-PatrickOFriel Jul 27, 2017

Choose a reason for hiding this comment

Blackbaud-SandhyaRajasabeson Jul 27, 2017

Choose a reason for hiding this comment

Blackbaud-PatrickOFriel commented Jul 27, 2017

Blackbaud-ToddRoberts commented Jul 27, 2017

Blackbaud-PatrickOFriel Jul 31, 2017

Choose a reason for hiding this comment

Blackbaud-PatrickOFriel Jul 31, 2017

Choose a reason for hiding this comment

Blackbaud-ToddRoberts Aug 1, 2017

Choose a reason for hiding this comment

Blackbaud-ToddRoberts Aug 1, 2017

Choose a reason for hiding this comment

Blackbaud-PatrickOFriel Aug 1, 2017

Choose a reason for hiding this comment

Blackbaud-PatrickOFriel commented Aug 1, 2017

Blackbaud-ToddRoberts commented Aug 1, 2017

Blackbaud-PatrickOFriel commented Jul 27, 2017 •

edited

Loading