Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip_domain_validation not working when using rustls #283

Closed
alekitto opened this issue Jan 10, 2024 · 0 comments · Fixed by #284
Closed

skip_domain_validation not working when using rustls #283

alekitto opened this issue Jan 10, 2024 · 0 comments · Fixed by #284

Comments

@alekitto
Copy link
Contributor

TLS skip_domain_validation is not respected when using rustls.

This line checks for "CertNotValidForName" string, but since rustls 0.21 the error is simply called NotValidForName, so the check fails and the connection cannot be completed.

Simply adjusting the checked string is sufficient to fix the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix skip_domain_validation usage when using rustls alekitto/mysql_async
1 participant
@alekitto