keepalive: allow setting of probe interval & probe count #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulara
force-pushed
the
keepalive-set-whats-needed
branch
2 times, most recently
from
d0c94d8
to
39cbf2b
Compare
Now this is ugly. And it got even uglier because socket2 has those damn `retries` and `interval` behind `all` feature flag...
fulara
force-pushed
the
keepalive-set-whats-needed
branch
2 times, most recently
from
3aea412
to
b0f5bea
Compare
fulara
force-pushed
the
keepalive-set-whats-needed
branch
from
b0f5bea
to
a61c5fe
Compare
|
Thanks. I'll merge it as it is. Windows support may be added as a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the library only allows setting of the keepalive idle time
I think that is driven by the fact the socket2 only exposes this code easily - that is without the
allfeature flag.Well, it's kinda odd that they do only that, so I have raised a PR there: rust-lang/socket2#294 but I am not sure if that will be merged and when.
In the meantime we can easily add the support of that into this crate, just by using more
rooAPI.