Skip to content

Commit

Permalink
log exceptions
Browse files Browse the repository at this point in the history
  • Loading branch information
thomas-kl1 committed Jun 12, 2019
1 parent 8387378 commit f802648
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 6 deletions.
19 changes: 14 additions & 5 deletions Service/OrangeSmsAdapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
use Magento\Framework\Exception\InputException;
use Magento\Framework\Phrase;
use Magento\Store\Model\ScopeInterface;
use Psr\Log\LoggerInterface;

/**
* Class OrangeSmsAdapter, connector to SmsNotification adapters
Expand Down Expand Up @@ -64,22 +65,30 @@ final class OrangeSmsAdapter implements AdapterInterface
*/
private $phoneNumberParser;

/**
* @var \Psr\Log\LoggerInterface
*/
private $logger;

/**
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
* @param \Blackbird\OrangeSms\Api\SmsBuilderInterface $smsBuilder
* @param \Blackbird\OrangeSms\Api\SmsManagementInterface $smsManagement
* @param \Blackbird\PhoneNumberLib\Parser\PhoneNumberParser $phoneNumberParser
* @param \Psr\Log\LoggerInterface $logger
*/
public function __construct(
ScopeConfigInterface $scopeConfig,
SmsBuilderInterface $smsBuilder,
SmsManagementInterface $smsManagement,
PhoneNumberParser $phoneNumberParser
PhoneNumberParser $phoneNumberParser,
LoggerInterface $logger
) {
$this->smsBuilder = $smsBuilder;
$this->smsManagement = $smsManagement;
$this->scopeConfig = $scopeConfig;
$this->phoneNumberParser = $phoneNumberParser;
$this->logger = $logger;
}

/**
Expand Down Expand Up @@ -119,10 +128,10 @@ public function sendMessage(MessageInterface $message): bool
$sms = $this->smsBuilder->create();

return $this->smsManagement->send($sms);
} catch (OrangeSmsSendException $e) {
throw new SendNotificationException(new Phrase('Could not send the message: %1', [$e->getMessage()]));
} catch (InputException $e) {
throw new SendNotificationException(new Phrase('Invalid SMS format: %1', [$e->getMessage()]));
} catch (\Exception $e) {
$this->logger->error($e->getMessage(), $e->getTrace());
}

return false;
}
}
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"roave/security-advisories": "dev-master"
},
"type": "magento2-module",
"version": "1.1.0",
"version": "1.1.1",
"license": [
"MIT"
],
Expand Down

0 comments on commit f802648

Please sign in to comment.