Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion about sorting buttons. #301

Closed
KostromDan opened this issue Mar 12, 2023 · 9 comments
Closed

Suggestion about sorting buttons. #301

KostromDan opened this issue Mar 12, 2023 · 9 comments

Comments

@KostromDan
Copy link

KostromDan commented Mar 12, 2023

At the moment, the mod adds sorting buttons exclusively to the inventory we are working with. This creates a problem, if I opened the chest, then the sort button will be exclusively for the chest inventory, but not for the player's inventory, and if I want to sort the player's inventory during the work with the chest, I will have to exit the chest, enter the inventory, sort the inventory, exit the inventory and return to the chest, I think it is not necessary to say that it is very inconvenient.
How it looks now:
image
How it should:
image
Also, if you add this feature, make sure it works with Sophisticated Backpacks and Sophisticated Storage, because other mods, that have this feature don't display sorting buttons in players inventory while working working with Sophisticated mods. But show in vanilla storages. Same thing with Mekanism.

@blackd
Copy link
Owner

blackd commented Mar 12, 2023

To be honest I don't really want to introduce additional GUI elements.
If you can switch to hotkey sorting you can make the mod sort the inventory that is under the mouse cursor.

@KostromDan
Copy link
Author

KostromDan commented Mar 12, 2023

"you can make the mod sort the inventory that is under the mouse cursor" - sounds interesting, I've tried it. I have locked the mouse wheel and it sorts only the barrel inventory, even if the mouse cursor is in the player's inventory area. I have disabled all other binds from other sorting mods. What am I doing wrong?
image

@blackd
Copy link
Owner

blackd commented Mar 12, 2023

there is an option in the Mod Settings that enable this.

I was set to false in the original mod before it was abandoned and I never got around to set it to true by default. I will do that in the next release.

@KostromDan
Copy link
Author

Now it works, thanks, but I would suggest that you think about the buttons, since not everyone knows how to use keyboard shortcuts and just use the mod as it is without additional settings.

@ejm554
Copy link

ejm554 commented Aug 5, 2024

To be honest I don't really want to introduce additional GUI elements.

I started using this mod about a month ago, and the main UX frustration I have is that I cannot sort my inventory with the standard button unless I go to the inventory view. The requires me to leave my current view, open my inventory, click the sort button, and then return to my previous view.

I decided to post this issue today, and I found that @KostromDan raised this same issue about a year ago. However, @blackd wasn't persuaded.

In case they (or one of the other contributors) are open to re-considering their stance, I'd like to advocate for the elegance of a button. As a user, having the same inventory-sort button on different screens seems intuitive. Also, I'm not a power user of this mod, so I'd also prefer not to tinker with hotkey settings.

Three screenshots, arranged horizontally, of an inventory view, a chest view, and a crafting table view, respectively.

@blackd
Copy link
Owner

blackd commented Aug 5, 2024

the default shortcut for sort is "R" and it works for the inventory under the mouse cursor.
I prefer not to add new buttons because of the numerous problems with modded GUIs

@blackd
Copy link
Owner

blackd commented Aug 6, 2024

I've decided to add another set of buttons

image

but they will be disabled by default

image

This will be available in the next 1.21+ release

@blackd blackd reopened this Aug 6, 2024
@blackd blackd closed this as completed Aug 6, 2024
blackd added a commit that referenced this issue Aug 6, 2024
Adds support for hotkey to toggle the overlay visibility.

closes #301
@ejm554
Copy link

ejm554 commented Aug 6, 2024

  • Thanks for adding this option.
  • Thanks for the tip about the "R" default shortcut.
  • Will this new feature work with 1.20.6 also?
  • What are those purple arrows shown at the bottom of one of your recent screenshots? ↴
Bottom row of a Minecraft inventory screen that includes some non-Vanilla purple arrows in the upper left of each cell

@blackd
Copy link
Owner

blackd commented Aug 6, 2024

no 1.20.6

in the latest version it's possible to enable auto refill per slot the arrows show if it's enabled or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants