create default app_service based on first service #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut allow it to still be overriden via `app_service` key
…ts in app.config.services
lolautruche
suggested changes
Nov 22, 2021
Comment on lines
+27
to
+31
| const closestService = _.first(options._app.info); | ||
| //now double-check to make sure the service object exists in config services. | ||
| if(options._app.config.services.hasOwnProperty(closestService.service)) { | ||
| config.app_service = closestService.service; | ||
| } |
There was a problem hiding this comment.
WS alignment 😉
Suggested change
| const closestService = _.first(options._app.info); | |
| //now double-check to make sure the service object exists in config services. | |
| if(options._app.config.services.hasOwnProperty(closestService.service)) { | |
| config.app_service = closestService.service; | |
| } | |
| const closestService = _.first(options._app.info); | |
| // now double-check to make sure the service object exists in config services. | |
| if(options._app.config.services.hasOwnProperty(closestService.service)) { | |
| config.app_service = closestService.service; | |
| } |
There was a problem hiding this comment.
my bad. Was using a different IDE from my preferred. Do we have a .editorconfig file we use to ensure proper spacing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If available, uses the first service in
options._app.infowhich is typically the primary service, to use as the defaultapp_servicebut if not available, retains the previousappservervalue. Also still allows for the value to be overridden from the lando.yaml file.Closes #3