-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: 📦 update release workflow with permissions and GoReleaser v6 #1
Conversation
WalkthroughThe changes made in the pull request primarily affect the GitHub Actions workflow file located at Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub
participant GoReleaser
User->>GitHub: Push tag "v1.0.0"
GitHub->>GoReleaser: Trigger release workflow
GoReleaser-->>GitHub: Perform release actions
GitHub-->>User: Notify release completion
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
.github/workflows/release.yml (1)
9-10
: LGTM: Explicit permissions setSetting explicit permissions is a good security practice. The
write
access tocontents
is necessary for creating releases and uploading assets.Consider being more specific with permissions if possible. If you only need to create releases and upload release assets, you could use:
permissions: contents: write packages: writeThis would restrict the workflow to only the necessary permissions for releasing.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- .github/workflows/release.yml (2 hunks)
🧰 Additional context used
🔇 Additional comments (2)
.github/workflows/release.yml (2)
4-7
: LGTM: Appropriate event triggers for releasesThe addition of the
push
event trigger for tags matching "v*.." is a good practice for automating releases based on semantic versioning tags. Retaining thepull_request
trigger allows for testing the release process on PRs, which is beneficial for catching issues before actual releases.
25-25
: LGTM: GoReleaser action and version updatesThe updates to the GoReleaser action and its version parameter are good improvements:
- Updating to
goreleaser/goreleaser-action@v6
ensures you're using the latest major version of the action, which may include important features and bug fixes.- Changing the version parameter to
"~> v2"
allows for compatible updates within v2. This is more stable than using "latest" while still allowing for minor version updates and patches.These changes strike a good balance between staying up-to-date and maintaining stability.
Also applies to: 28-28
This pull request includes updates to the GitHub Actions workflow for releases, specifically in the
release.yml
file. The main changes involve adding tag-based triggers, updating permissions, and modifying job steps to use more current versions and configurations.Workflow updates:
.github/workflows/release.yml
: Added tag-based triggers for the workflow to run on pushes to tags matching the patternv*.*.*
..github/workflows/release.yml
: Added permissions to allow writing contents.Job configuration updates:
.github/workflows/release.yml
: Updated the Go setup step to use the stable version instead of a specific version..github/workflows/release.yml
: Removed the test running step..github/workflows/release.yml
: Updated the GoReleaser action to use version 6 and specified the version constraint~> v2
.Summary by CodeRabbit