New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCLMC Info should not scale kinetic_change again #625

Closed

junpenglao opened this issue Dec 10, 2023 · 0 comments · Fixed by #626

Member

junpenglao commented Dec 10, 2023

Describe the issue as clearly as possible:

@reubenharry I notice a small bug here: generalized_two_stage_integrator contains a short circuit for the 2nd step of O1 when it is last call, so it can avoid some computation. In the case of noneuclidean_* integrators, it would scale the kinetic_change with (dim - 1).

So the * (dim - 1) in

blackjax/blackjax/mcmc/mclmc.py

Line 98 in e05b5fe

kinetic_change=kinetic_change * (dim - 1),

should be removed.

Steps/code to reproduce the bug:

Na

Expected result:

Na

Error message:

No response

Blackjax/JAX/jaxlib/Python version information:

Current blackjax main

Context for the issue:

See reference implementation in https://github.com/JakobRobnik/MicroCanonicalHMC/blob/master/mclmc/dynamics.py

The text was updated successfully, but these errors were encountered:

junpenglao assigned junpenglao and unassigned junpenglao

junpenglao mentioned this issue

Update noneuclidean integrator #626

Merged

junpenglao added a commit to junpenglao/blackjax that referenced this issue


          Fix blackjax-devs#625

ddf75f0

junpenglao closed this as completed in #626

junpenglao added a commit that referenced this issue


          Update noneuclidean integrator (#626)

fac1d5e

* Update noneuclidean integrator

to match default implmentation in https://github.com/JakobRobnik/MicroCanonicalHMC/blob/master/mclmc/dynamics.py

* fix formatting

* Fix #625

junpenglao added a commit that referenced this issue


          Update noneuclidean integrator (#626)

* Update noneuclidean integrator

to match default implmentation in https://github.com/JakobRobnik/MicroCanonicalHMC/blob/master/mclmc/dynamics.py

* fix formatting

* Fix #625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment