Allow users to pass a float for constant learning rate #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current API requires user to pass a function of the index of the current iteration, even when the learning rate is constant. However, in practice most people use a constant learning rate (even if they shouldn't, but who are we to judge?) and we should simplify that pattern of use. This commit thus allows users to pass either a function, either a float as learning rate to the kernel builder. It will raise an exception for any other type.
Codecov Report
@@ Coverage Diff @@
## main #293 +/- ##
==========================================
- Coverage 98.79% 98.69% -0.10%
==========================================
Files 46 46
Lines 1905 1917 +12
==========================================
+ Hits 1882 1892 +10
- Misses 23 25 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
codevoc is not catching the test cases that check that a |
junpenglao
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current API requires user to pass a function of the index of the current iteration, even when the learning rate is constant. However, in practice most people use a constant learning rate (even if they shouldn't, but who are we to judge?) and we should simplify that pattern of use.
This commit thus allows users to pass either a function, either a float as learning rate to the kernel builder. It will raise an exception for any other type.