-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify linear regressions to parameters in R #388
Modify linear regressions to parameters in R #388
Conversation
Codecov Report
@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 45 45
Lines 2184 2184
=======================================
Hits 1960 1960
Misses 224 224 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks! Why use flat priors? |
I think it is better to keep the prior and add the forward log jacobian. @rlouf wdyt? |
We had the same thought at the same time 😄 |
Could you also update the one in:
Optional the ones in examples. |
b008627
to
465bedb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor comments.
465bedb
to
3a05028
Compare
Great. Added a reminder in the introduction notebook to reparametrize before MCMC. |
LGTM, thank you for doing the unsexy work! |
Closes #378
As a side note: If initial parameters for the$1.0$ in
log_scale
are set toregression_test_cases
onlytest_pathfinder_adaptation
fails with samples forlog_scale
diverging toinf
.