Fix parent_url() to remove querystring #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1820 +/- ##
=====================================
+ Coverage 93% 93% +1%
=====================================
Files 348 348
Lines 27162 27163 +1
=====================================
+ Hits 25060 25062 +2
+ Misses 2102 2101 -1 ☔ View full report in Codecov by Sentry. |
TheTechromancer
approved these changes
Oct 4, 2024
TheTechromancer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querystring was present (like when parameter extraction is enabled) the parent_url helper was retaining the querystring as it traversed up the directory structure, leading to malformed URLs being speculated.