Fix: Trufflehog Accepting already parsed files #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domwhewell-sage
changed the title
|
Should we move the folder -> file logic to speculate/excavate? The functionality of converting a folder into files seems generic enough it should be builtin. What do you think? |
|
@TheTechromancer yeh, speculate could probably do it having the folders re-raised per file allows their raw text to be raised so excavate can extract text from there |
TheTechromancer
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1812 trufflehog was sometimes accepting files from folders that had already been scanned, this was bypassing the filter added in #1720.
This PR partially reverses #1720 and changes the filter to not accept any
FILESYSTEMevents tagged withparsed-folder, this will prevent it accepting a file from a git repo then scanning the git repo folder (as its a separate event)