command: Ditched the nasty stack buffer in preference for direct form…

…atting the probe information out to GDB for the version command

src/command.c

@@ -186,10 +186,8 @@ bool cmd_version(target_s *target, int argc, const char **argv)
 	(void)argc;
 	(void)argv;
 #if PC_HOSTED == 1
-	char ident[256];
-	gdb_ident(ident, sizeof(ident));
 	gdb_out("Black Magic Debug App " FIRMWARE_VERSION "\n");
-	gdb_outf("Using a %s\n", ident);
+	bmda_display_probe();
 #else
 #ifndef PLATFORM_IDENT_DYNAMIC
 	gdb_out(BOARD_IDENT);

src/platforms/hosted/platform.c

@@ -69,9 +69,9 @@ static uint32_t max_frequency = 4000000U;
 
 static bmda_cli_options_s cl_opts;
 
-void gdb_ident(char *p, int count)
+void bmda_display_probe(void)
 {
-	snprintf(p, count, "%s (%s), %s", bmda_probe_info.manufacturer, bmda_probe_info.product, bmda_probe_info.version);
+	gdb_outf("Using a %s (%s), %s\n", bmda_probe_info.product, bmda_probe_info.manufacturer, bmda_probe_info.version);
 }
 
 static void exit_function(void)

src/platforms/hosted/platform.h

@@ -87,7 +87,7 @@ typedef enum probe_type {
 	PROBE_TYPE_GPIOD,
 } probe_type_e;
 
-void gdb_ident(char *p, int count);
+void bmda_display_probe(void);
 
 #ifdef ENABLE_GPIOD
 #include "bmda_gpiod_platform.h"