Code

Fix: ARM JTAG regressions#1389

Code

Merged

esden merged 56 commits intomainblackmagic-debug/blackmagic:mainfrom fix/arm-jtag-regressionsblackmagic-debug/blackmagic:fix/arm-jtag-regressionsCopy head branch name to clipboardApr 3, 2023

+754-567

Commits

Commits on Apr 2, 2023

• remote: Cleaned up and rewrote remote_send_buf()

  

  dragonmux

  authored and

  esden

  committed
  f65f240

• remote: Cleaned up remote_respond_buf()

  

  dragonmux

  authored and

  esden

  committed
  a0bc82f

• remote: Systematically worked through and fixed remote_packet_process_high_level()

  

  dragonmux

  authored and

  esden

  committed
  9a42802

• common/jtagtap: Removed the jtag_next_tms_tdi() helper to explore retiming to improve compatability between ARM and RISC-V timing needs

  

  dragonmux

  authored and

  esden

  committed
  bcd923c

• adiv5: Cleanup and const correctness in adiv5_dp_init()

  

  dragonmux

  authored and

  esden

  committed
  cf5d280

• common/jtagtap: Further work opening the timings on jtagtap_tdi_tdo_seq_no_delay()

  

  dragonmux

  authored and

  esden

  committed
  c7907ba

• adiv5: Fixed CMSIS-DAP JTAG adaptors like OBRTrace going off the rails when spinning up a DP

  

  dragonmux

  authored and

  esden

  committed
  0718c5f

• hosted/dap: Cleaned up the implementation of dap_jtag_configure and documented how it works

  

  dragonmux

  authored and

  esden

  committed
  852fcd1

• common/jtagtap: jtagtap_tdi_tdo_seq_no_delay must write to data_out on finishing when clock_cycles is not a multiple of 8

  

  dragonmux

  authored and

  esden

  committed
  f4ee6b2

• common/jtagtap: Re-timed jtagtap_tdi_seq_no_delay() slightly to improve the TDI timings

  

  dragonmux

  authored and

  esden

  committed
  407b93b

• remote: Begun defining a new version of the remote protocol so the ADIv5 high level functions can report errors

  

  dragonmux

  authored and

  esden

  committed
  3ec44c8

• remote: Cleaned up the header ready for the introduction of the ADIv5 protocol

  

  dragonmux

  authored and

  esden

  committed
  35a61fe

• remote: Implemented a new version of REMOTE_DP_READ

  

  dragonmux

  authored and

  esden

  committed
  1689a5c

• hex_utils: Replace the hexdigits array with a function

  

  dragonmux

  authored and

  esden

  committed
  497adf9

• hex_utils: Made the hex_digit and unhex_digit functions available to the rest of the firmware

  

  dragonmux

  authored and

  esden

  committed
  9ccae8d

• remote: Cleaned up and rewrote remote_respond()

  

  dragonmux

  authored and

  esden

  committed
  9a7d928

• remote: Corrected the naming of remote_hex_string_to_num from remotehston

  

  dragonmux

  authored and

  esden

  committed
  2785383

• remote: Cleaned up and rewrote remote_respond_string()

  

  dragonmux

  authored and

  esden

  committed
  40327fa

• remote: Implemented a new version of REMOTE_ADIv5_RAW_ACCESS (was REMOTE_LOW_ACCESS)

  

  dragonmux

  authored and

  esden

  committed
  ac79d70

• remote: Impelemented new versions of REMOTE_AP_READ and REMOTE_AP_WRITE

  

  dragonmux

  authored and

  esden

  committed
  b2e7990

• remote: Fixed the ADIv5 protocol definitions for memory access

  

  dragonmux

  authored and

  esden

  committed
  e1611f2

• main: Ensured alignment of the packet buffer and allowed the remote protocol layer access to it

  

  dragonmux

  authored and

  esden

  committed
  eb18700

• remote: Implemented a new version of REMOTE_MEM_READ

  

  dragonmux

  authored and

  esden

  committed
  64fef3d

• remote: Documented more of how remote_packet_process_adiv5() works

  

  dragonmux

  authored and

  esden

  committed
  47f1560

• remote: Implemented a new version of REMOTE_MEM_WRITE

  

  dragonmux

  authored and

  esden

  committed
  418eb73

• remote: Do at least any validation on the packet length going into remote_packet_process_adiv5()

  

  dragonmux

  authored and

  esden

  committed
  57dfec3

• remote: Moved the JTAG device fill command into the high-level command set proper

  

  dragonmux

  authored and

  esden

  committed
  ea090f5

• remote: Refactored out some of the formatting strings to ease readability and ensuring correctness

  

  dragonmux

  authored and

  esden

  committed
  b35d44d

• remote: Fixed up the parameters to remote_packet_process_high_level()

  

  dragonmux

  authored and

  esden

  committed
  7b4432e

• remote: Folded the protocol version check command into the high level command switch-case

  

  dragonmux

  authored and

  esden

  committed
  da9836f

• remote: Cleaned up the implementation of REMOTE_ADD_JTAG_DEV

  

  dragonmux

  authored and

  esden

  committed
  d4e0ae9

• hosted/bmp_remote: Fixed the input types to the platform_buffer_*() functions

  

  dragonmux

  authored and

  esden

  committed
  a5cb710

• hosted/bmp_remote: Corrected for the renaming in the remote protocol header

  

  dragonmux

  authored and

  esden

  committed
  156eae1

• hosted/bmp_remote: Fixed the clang-tidy lints in remote_add_jtag_dev()

  

  dragonmux

  authored and

  esden

  committed
  35e94fe

• hosted/bmp_remote: Cleaned up and fixed various clang-tidy lints

  

  dragonmux

  authored and

  esden

  committed
  9c414da

• general: Fixed several clang-tidy lints about BMDA's DEBUG_ functions

  

  dragonmux

  authored and

  esden

  committed
  172aa64

• hosted/remote_jtagtap: Removed all the platform_buffer_* function casts now they're not necessary

  

  dragonmux

  authored and

  esden

  committed
  549b4f2

• hosted/remote_swdptap: Removed all the platform_buffer_* function casts now they're not necessary

  

  dragonmux

  authored and

  esden

  committed
  f7067b0

• hosted/bmp_remote: Simplified remote_init() as the REMOTE_START_STR does not need formatting

  

  dragonmux

  authored and

  esden

  committed
  6125803

• adiv5: Fixed the nomenclature of the device index member of the DP structure

  

  dragonmux

  authored and

  esden

  committed
  22f9cf8

• hosted/bmp_remote: Implemented new error handling machinary for ADIv5 remote commands

  

  dragonmux

  authored and

  esden

  committed
  ef08820

• hosted/bmp_remote: Reimplemented the DP read handler using the new machinary

  

  dragonmux

  authored and

  esden

  committed
  aa9d288

• hosted/bmp_remote: Reimplemented the raw access handler using the new machinary

  

  dragonmux

  authored and

  esden

  committed
  8cb2fdf

• hosted/bmp_remote: Reimplemented the AP read handler using the new machinary

  

  dragonmux

  authored and

  esden

  committed
  8cb4809

• hosted/bmp_remote: Reimplemented the AP write handler using the new machinary

  

  dragonmux

  authored and

  esden

  committed
  34edcd1

• hosted/bmp_remote: Reimplemented the ADIv5 memory read handler using the new machinary

  

  dragonmux

  authored and

  esden

  committed
  8380070

• hosted/bmp_remote: Reimplemented the ADIv5 memory write handler using the new machinary

  

  dragonmux

  authored and

  esden

  committed
  233b0e4

• hosted/bmp_remote: Overhaulled the high-level remote protocol version check

  

  dragonmux

  authored and

  esden

  committed
  184fd62

• remote: Implemented exception handling around the ADIv5 high-levle remote protocol

  

  dragonmux

  authored and

  esden

  committed
  935238c

• hosted/bmp_remote: Implemented handling for exceptions propegated through the remote protocol system

  

  dragonmux

  authored and

  esden

  committed
  9a58408

• adiv5_jtagdp: Fixed the behaviour of adiv5_jtagdp_error() under BMDA as this call would fail to function properly and screw up probing for parts

  

  dragonmux

  authored and

  esden

  committed
  6d8dbe3

• hosted/cmsis_dap: Fixed the implementation of dap_jtag_dp_error() to not trigger a write when there is no need for the ABORT DP register

  

  dragonmux

  authored and

  esden

  committed
  932849b

• hosted/dap_command: Fixed several clang-tidy lints in the decls

  

  dragonmux

  authored and

  esden

  committed
  9211f78

• hosted/cmsis_dap: Removed the custom JTAG error recovery function in favour of the one baked into the firmware as the firmware one is more correct

  

  dragonmux

  authored and

  esden

  committed
  8ec851f

• cortexm: Fix target resumption on detach for some targets

  

  dragonmux

  authored and

  esden

  committed
  51267d8

• hoted/cmsis_dap: Changed the phase when dap_jtag_configure() is called as it was happening too late

  

  dragonmux

  authored and

  esden

  committed
  7d04143