Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: SWD to JTAG sequence #1443

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Fix: SWD to JTAG sequence #1443

merged 2 commits into from
Apr 10, 2023

Conversation

dragonmux
Copy link
Member

Detailed description

Due to an issue with marginal timings on some devices, SWD->JTAG sequence operations were not reliable after #1389 and #1430. This PR addresses this by adding the = back into the <= 50 condition used to generate enough idle cycles before the sequence and documenting it as intended behaviour.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

dragonmux added 2 commits April 7, 2023 01:51
@dragonmux
common/jtagtap: Turns out that the = in i <= 50 in jtagtap_init() i…
43f9af2 
…s required to help otherwise marginal parts along with the SWD->JTAG sequence
@dragonmux
hosted/libftdi_jtagtap: Turns out that the = in i <= 50 in jtagtap_…
7c69235 
…init() is required to help otherwise marginal parts along with the SWD->JTAG sequence
@dragonmux dragonmux added Bug Confirmed bug Regression Bug caused by a regression labels Apr 7, 2023
@dragonmux dragonmux added this to the v1.10 milestone Apr 7, 2023
@dragonmux dragonmux requested a review from esden April 7, 2023 17:17
@dragonmux dragonmux marked this pull request as ready for review April 7, 2023 17:17
esden
esden approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested this with the 1Bitsy which was exhibiting the issue and this patch fixes it.

@esden esden added this pull request to the merge queue Apr 10, 2023
Merged via the queue into main with commit e75251d Apr 10, 2023
@dragonmux dragonmux deleted the fix/swd-to-jtag-sequence branch April 10, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esden esden esden approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bug Regression Bug caused by a regression
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@dragonmux @esden